Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add tags to datasets #18

Open
mfiume opened this issue Apr 8, 2016 · 13 comments
Open

Add tags to datasets #18

mfiume opened this issue Apr 8, 2016 · 13 comments
Labels
stalled No plans to implement it in the short term theme:Response Beacon Response Format type:feature

Comments

@mfiume
Copy link
Contributor

mfiume commented Apr 8, 2016

Add arbitrary text tags that can be used to denote, for example, if the dataset is from case-level observations or curated annotation, whole exome or whole genome, population, geographic region, etc.

@mfiume mfiume added the proposal label Apr 8, 2016
@mfiume mfiume added this to the beacon-api-v0.3 milestone Apr 8, 2016
@mfiume
Copy link
Contributor Author

mfiume commented Apr 14, 2016

Alternatively, we could add specific fields. I suggest at least the following:

type = { case-level, annotation, any string }
population = { any string }
scope = { genome , exome, any string }

@jrambla
Copy link
Collaborator

jrambla commented Apr 19, 2016

Are you suggesting a kind of "info" field for the dataset?
In positive +1

@mcupak mcupak modified the milestones: 1.0, 0.3 May 3, 2016
@mcupak
Copy link
Contributor

mcupak commented May 3, 2016

Agreed to postpone to 1.0.

@mcupak mcupak removed the proposal label Jun 28, 2016
@mfiume mfiume modified the milestones: 0.4, 1.x Nov 3, 2016
@mfiume
Copy link
Contributor Author

mfiume commented Nov 3, 2016

This is becoming increasingly important as the number of beacons increases.

Also, beacons that serve in silico predictions respond "true" for most alleles. It should be made clear to beacon users that these are not really observed, but hypothetical. We get a lot of excited emails about hits on SolveBio's dbNSFP Beacon for example.

@david4096
Copy link
Contributor

david4096 commented Nov 3, 2016

The g4 schemas have a string:List tag that is on the Dataset message for exchanging arbitrary data that is not in named fields.

https://github.com/ga4gh/schemas/blob/master/src/main/proto/ga4gh/metadata.proto#L45

@sdelatorrep
Copy link
Contributor

@mfiume, can the "info" field already present in BeaconDataset be used for this purpose (as @jrambla suggested)?

@mfiume
Copy link
Contributor Author

mfiume commented Apr 20, 2017

Yes, just a matter of whether we'd like to standardize this so that networks can rely on consistent fields. WDYT @sdelatorrep?

@mbaudis
Copy link
Member

mbaudis commented Apr 21, 2017

While in personal use I'm all for "tags", a better way (when having the power to develop in a forward looking way) is to do this in a proper object way. This means:

  • no simple "guess what they mean" tags
  • no "named attribute for everything"

Similar to the (still not master but pretty much settled) "characteristics" attribute https://github.com/ga4gh/ga4gh-schemas/blob/metadata-integration/src/main/proto/ga4gh/bio_metadata.proto#L101

@sdelatorrep
Copy link
Contributor

@mfiume we believe we should close this issue and open a new one when we have specific tags to include. Or you already have some?

@sdelatorrep
Copy link
Contributor

Any new on this? Should we move the issue to another milestone? Or close it and reopen it when we eventually have some requirements?

@mbaudis
Copy link
Member

mbaudis commented Sep 5, 2017

@sdelatorrep Probably best to do this with concrete implementation. Also, evaluate then use of ontology terms (e.g. EFO) instead of arbitrary tags / typed values.

@susheel
Copy link
Member

susheel commented Sep 12, 2017

@mfiume @mbaudis
Suggest we move to next milestone - v1.0
Reason: Requirements for adding tags to datasets are not clear. No real-world use case to test.

@susheel
Copy link
Member

susheel commented Sep 15, 2017

Moving to next milestone v0.5

@susheel susheel modified the milestones: 0.4, 0.5 Sep 15, 2017
@juhtornr juhtornr added the theme:Response Beacon Response Format label Mar 16, 2018
@jrambla jrambla removed this from the 1.0.2 milestone Sep 18, 2018
@jrambla jrambla added the stalled No plans to implement it in the short term label Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stalled No plans to implement it in the short term theme:Response Beacon Response Format type:feature
Projects
None yet
Development

No branches or pull requests

8 participants