Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LegacyVariation or VRS? #44

Open
mshadbolt opened this issue Jul 21, 2022 · 3 comments
Open

LegacyVariation or VRS? #44

mshadbolt opened this issue Jul 21, 2022 · 3 comments

Comments

@mshadbolt
Copy link
Contributor

Quick question re: genomicVariants, does the Beacon team recommend following the VRS variant specification (i.e. either MolecularVariation or SystemicVariation) for defining the variation field in genomicVariant objects or are you agnostic to which reference is used?

I am not sure whether the LegacyVariation definition is something to ensure backward compatibility only and it is preferred to use the VRS schemas for any new beacons or it is still a valid option moving forward?

@mbaudis
Copy link
Member

mbaudis commented Jul 22, 2022

@mshadbolt Good question. We probably should be more empathic about using VRS - however, this had been a bit of a moving target during late development/approval of Beacon v2, therefore the half-hearted implementation & documentation. The "legacy" part (e.g. "variantType": "SNP", "alternateBases": "A" ...) was primarily as an offer to implementers who may not yet be on the VRS track (i.e. most) to provide a soft landing.

IMO we should emphasize VRS format (in fact the location part of the "legacy" type also uses VRS locations). It would be great if you could e.g. PR some examples here https://github.com/ga4gh-beacon/beacon-v2/tree/main/models/src/beacon-v2-default-model/genomicVariations/examples !

@mshadbolt
Copy link
Contributor Author

Ok great, thanks @mbaudis , thanks for confirming. It makes sense to me that the VRS approach would be favoured moving forward.

Our group is working on generating some examples for our own purposes so will definitely add some examples via a PR when I have generated some.

@mbaudis
Copy link
Member

mbaudis commented Nov 5, 2024

@mshadbolt WDYT about moving to a more VRS vocabulary in queries, e.g. alternateBases => sequence, ditching referenceBases and assemblyId ... etc.? I'm interested in getting users' opinions (I'm in favour).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants