Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve datatype of runs:platform to OntologyTerm #35

Open
joerivandervelde opened this issue Jul 11, 2022 · 1 comment
Open

Improve datatype of runs:platform to OntologyTerm #35

joerivandervelde opened this issue Jul 11, 2022 · 1 comment

Comments

@joerivandervelde
Copy link

The datatype of runs:platform could be changed from String to OntologyTerm, using as value range the terms listed under https://www.ebi.ac.uk/ols/ontologies/genepio/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FGENEPIO_0000071. That would make the data more interoperable. In case the data doesn't fit, perhaps null flavors could be used (https://raw.githubusercontent.com/fairgenomes/fairgenomes-semantic-model/main/lookups/NullFlavors.txt), or a new term introduced locally.

@mbaudis
Copy link
Member

mbaudis commented Jul 11, 2022

@joerivandervelde I guess this was left open (as string) since no good ontology branch for diverse platforms exists - e.g. the one you link to is very incomplete and specific for sequencing platforms.

As with your other issues you posted today: Yes, these could be implemented (as even indicated for some ...) but then need some broadly working examples. See e.g. platformModel. So feel free to craft a PR ... Generally: ontology terms/trees are suggested in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants