Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phenopackify disease #26

Open
mbaudis opened this issue Jun 20, 2022 · 0 comments
Open

Phenopackify disease #26

mbaudis opened this issue Jun 20, 2022 · 0 comments
Labels
Model related

Comments

@mbaudis
Copy link
Member

mbaudis commented Jun 20, 2022

The disease class is still missing a number of parameters from Phenopackets v2 or represents them slightly different. We should:

  • rename ageOfOnset to onset, since it could be another time element
  • add resolution
  • add excluded flag option (CAVE: should we add "default": false?)
  • add clinicalTnmFinding
  • add primarySite
  • add laterality

This is a call for re-implementing the changes suggested here, directly in the unified beacon-v2 project:

ga4gh-beacon/beacon-v2-Models#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Model related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbaudis @jrambla