Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional parameters for GET queries and documentation of use vs. POST/schemas #21

Open
mbaudis opened this issue Feb 21, 2022 · 1 comment

Comments

@mbaudis
Copy link
Member

mbaudis commented Feb 21, 2022

As per various discussions, using GET request seems a rather widely used concept with implementers (rapid UI integration w/o need of using specific frameworks; easier documentation, examples, testing etc.). In fact, while we also implement POST in parallel, for Progenetix so far we rely on GET.

I would propose that we provide an extended matrix for parameters in GET queries. Examples here are

  • includeDescendantTerms - this can in POST be provided per filter but works for "medium complex use cases" as a global parameter
  • requestedGranularity, includeResultsetResponses - simple globals, but need to be documented that they can be used in GET
  • requestedSchemas - could be supported as resolving to entityType?
  • ...

IMO it would be much easier for many implementers to see such parameters as simple query parameters, and then the comparable documentation of the POST schemas.

Also see ga4gh-beacon/beacon-framework-v2#43

@mbaudis mbaudis transferred this issue from ga4gh-beacon/beacon-framework-v2 May 16, 2022
@jrambla
Copy link
Contributor

jrambla commented Jul 19, 2022

Is your suggestion about adding these parameters to the endpoints.yaml files?

@mbaudis mbaudis assigned mbaudis and unassigned mbaudis Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants