Rename email "activation" to "verification"

Author: LaurentTreguier

…/fyreplace/api/data/EmailActivation.java …yreplace/api/data/EmailVerification.javasrc/main/java/app/fyreplace/api/data/EmailActivation.java renamed to src/main/java/app/fyreplace/api/data/EmailVerification.java src/main/java/app/fyreplace/api/data/EmailActivation.java renamed to src/main/java/app/fyreplace/api/data/EmailVerification.java

@@ -4,7 +4,7 @@
 import jakarta.validation.constraints.NotBlank;
 import org.eclipse.microprofile.openapi.annotations.media.Schema;
 
-public record EmailActivation(
+public record EmailVerification(
         @NotBlank
                 @Length(min = Email.EMAIL_MIN_LENGTH, max = Email.EMAIL_MAX_LENGTH)
                 @jakarta.validation.constraints.Email

src/main/java/app/fyreplace/api/endpoints/EmailsEndpoint.java

@@ -2,8 +2,8 @@
 
 import app.fyreplace.api.cache.DuplicateRequestKeyGenerator;
 import app.fyreplace.api.data.Email;
-import app.fyreplace.api.data.EmailActivation;
 import app.fyreplace.api.data.EmailCreation;
+import app.fyreplace.api.data.EmailVerification;
 import app.fyreplace.api.data.RandomCode;
 import app.fyreplace.api.data.User;
 import app.fyreplace.api.emails.EmailVerificationEmail;
@@ -170,7 +170,7 @@ public long countEmails() {
     }
 
     @POST
-    @Path("activate")
+    @Path("verify")
     @Authenticated
     @Transactional
     @RequestBody
@@ -184,7 +184,7 @@ public long countEmails() {
                             schema = @Schema(implementation = ViolationReport.class)))
     @APIResponse(responseCode = "404", description = "Not Found")
     @CacheResult(cacheName = "requests", keyGenerator = DuplicateRequestKeyGenerator.class)
-    public Response activateEmail(@NotNull @Valid final EmailActivation input) {
+    public Response verifyEmail(@NotNull @Valid final EmailVerification input) {
         final var email = Email.<Email>find("email", input.email()).firstResult();
 
         try (final var stream = RandomCode.<RandomCode>stream("email", email)) {

…endpoints/emails/ActivateEmailTests.java …g/endpoints/emails/VerifyEmailTests.javasrc/test/java/app/fyreplace/api/testing/endpoints/emails/ActivateEmailTests.java renamed to src/test/java/app/fyreplace/api/testing/endpoints/emails/VerifyEmailTests.java src/test/java/app/fyreplace/api/testing/endpoints/emails/ActivateEmailTests.java renamed to src/test/java/app/fyreplace/api/testing/endpoints/emails/VerifyEmailTests.java

@@ -5,7 +5,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import app.fyreplace.api.data.Email;
-import app.fyreplace.api.data.EmailActivation;
+import app.fyreplace.api.data.EmailVerification;
 import app.fyreplace.api.data.RandomCode;
 import app.fyreplace.api.data.User;
 import app.fyreplace.api.endpoints.EmailsEndpoint;
@@ -23,7 +23,7 @@
 
 @QuarkusTest
 @TestHTTPEndpoint(EmailsEndpoint.class)
-public final class ActivateEmailTests extends UserTestsBase {
+public final class VerifyEmailTests extends UserTestsBase {
     @Inject
     RandomService randomService;
 
@@ -33,53 +33,53 @@ public final class ActivateEmailTests extends UserTestsBase {
 
     @Test
     @TestSecurity(user = "user_0")
-    public void activateEmail() {
+    public void verifyEmail() {
         given().contentType(ContentType.JSON)
-                .body(new EmailActivation(newEmail.email, randomCodeClearText))
-                .post("activate")
+                .body(new EmailVerification(newEmail.email, randomCodeClearText))
+                .post("verify")
                 .then()
                 .statusCode(200);
         assertEquals(0, RandomCode.count("id", randomCode.id));
     }
 
     @Test
     @TestSecurity(user = "user_0")
-    public void activateEmailWithInvalidEmail() {
+    public void verifyEmailWithInvalidEmail() {
         given().contentType(ContentType.JSON)
-                .body(new EmailActivation("invalid", randomCodeClearText))
-                .post("activate")
+                .body(new EmailVerification("invalid", randomCodeClearText))
+                .post("verify")
                 .then()
                 .statusCode(400);
         assertEquals(1, RandomCode.count("id", randomCode.id));
     }
 
     @Test
     @TestSecurity(user = "user_0")
-    public void activateEmailWithOtherEmail() {
+    public void verifyEmailWithOtherEmail() {
         final var otherUser = requireNonNull(User.findByUsername("user_1"));
         given().contentType(ContentType.JSON)
-                .body(new EmailActivation(otherUser.mainEmail.email, randomCodeClearText))
-                .post("activate")
+                .body(new EmailVerification(otherUser.mainEmail.email, randomCodeClearText))
+                .post("verify")
                 .then()
                 .statusCode(404);
         assertEquals(1, RandomCode.count("id", randomCode.id));
     }
 
     @Test
     @TestSecurity(user = "user_0")
-    public void activateEmailWithInvalidCode() {
+    public void verifyEmailWithInvalidCode() {
         given().contentType(ContentType.JSON)
-                .body(new EmailActivation(newEmail.email, "invalid"))
-                .post("activate")
+                .body(new EmailVerification(newEmail.email, "invalid"))
+                .post("verify")
                 .then()
                 .statusCode(404);
         assertEquals(1, RandomCode.count("id", randomCode.id));
     }
 
     @Test
     @TestSecurity(user = "user_0")
-    public void activateEmailWithEmptyInput() {
-        given().contentType(ContentType.JSON).post("activate").then().statusCode(400);
+    public void verifyEmailWithEmptyInput() {
+        given().contentType(ContentType.JSON).post("verify").then().statusCode(400);
         assertEquals(1, RandomCode.count("id", randomCode.id));
     }