Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about "option is deprecated" #293

Closed
schmunk42 opened this issue Apr 10, 2017 · 5 comments
Closed

Question about "option is deprecated" #293

schmunk42 opened this issue Apr 10, 2017 · 5 comments
Labels

Comments

@schmunk42
Copy link
Contributor

The "extra.asset-installer-paths" option is deprecated, use the "config.fxp-asset.installer-paths" option
The "extra.asset-pattern-skip-version" option is deprecated, use the "config.fxp-asset.pattern-skip-version" option
The "extra.asset-vcs-driver-options" option is deprecated, use the "config.fxp-asset.vcs-driver-options" option

Does this mean I should switch ASAP, but it's still recognized - or doesn't it have any affect all now?

@francoispluchino
Copy link
Member

See the section Dreprecated options in the release page.

  1. The deprecated options are not removed to keep the compatibility
  2. All the options in the extra section are functional, and a warning will appear in the console if they are used
  3. All the options in the config.fxp-asset section will override the options still defined in the extra section

@schmunk42
Copy link
Contributor Author

All the options in the config.fxp-asset section will override the options still defined in the extra section

What if I have defined "old" options in extra, like vcs-driver-options and "new" ones in config like git-skip-update, will they get merged?

@francoispluchino
Copy link
Member

Only the first key, like the behavior of the array_merge function, and not like the array_merge_recursive function, so no.

But if you interested to add this behavior, It's in the method Fxp\Composer\AssetPlugin\Config\ConfigBuilder::injectDeprecatedConfig() that it happens.

@schmunk42
Copy link
Contributor Author

schmunk42 commented Apr 10, 2017

It's related to #292 - I refactored some composer.json files and noticed, that the asset-plugin started to do API requests again, although I've disabled them in the (extra) config.

Maybe it would be an option to enforce configuration either via extra (with a warning) or via config - but if both are specified the plugin would exit with an error. WDYT?

@francoispluchino
Copy link
Member

I think it would be better to merge the sub-options between extra and config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants