Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we support basic types for ChannelKinds? #11

Closed
dhylands opened this issue Apr 2, 2016 · 1 comment
Closed

Should we support basic types for ChannelKinds? #11

dhylands opened this issue Apr 2, 2016 · 1 comment

Comments

@dhylands
Copy link

dhylands commented Apr 2, 2016

For example, I need a String getter/setter to get/set the camera_name, username, and password, and it seems kind of lame that I need to create Extensions to do this.

Perhaps we can have a simple extension kind that is just a JSON object?
Why do we need a vendor for custom kinds and not for OnOff?

@Yoric
Copy link

Yoric commented Apr 2, 2016

If you don't mind, could you move that discussion to fxbox/deprecated-taxonomy#72? Unless I'm missing something, that doesn't really seem sound like RFC fodder to me.

As mentioned over there, ChannelKind is not about types but about feature discovery. As neither String nor JSON is a feature, neither fits in ChannelKind. I don't see why you would create an Extension rather than a new variant, though. Since Name, Username and Password are pretty generic features, they would definitely fit in ChannelKind (at least until we adopt a plan for #8 and get rid of ChannelKind entirely).

Regarding vendor: it's the name of whoever came up with the extension. Basically, it's a namespace, to avoid mismatches between two extensions with the same name.

@dhylands dhylands closed this as completed Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants