Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-command monitor handling should have a "screen" prefix #965

Closed
ThomasAdam opened this issue Mar 20, 2024 · 0 comments
Closed

Per-command monitor handling should have a "screen" prefix #965

ThomasAdam opened this issue Mar 20, 2024 · 0 comments
Assignees
@ThomasAdam
Labels
type:breaking Issue is not backwards-compatible and will break configs/build
Milestone
1.1.0

Comments

@ThomasAdam
Copy link
Member

ThomasAdam commented Mar 20, 2024 •
edited
Loading

There are some commands which have a literal screen prefix to denote which screen/monitor the command applies to, such as:

EWMHBaseStruts screen HDMI-1 0 0 0 0

But there are many others which do not, such as:

GotoDesk HDMI-1 0 0

This inconsistency makes command parsing a nightmare, since the overall length is variable; the presence of a literal screen keyword to denote the presence of a given screen would help solve this.

Commands which need changing:

  • GotoPage
  • GotoDesk
  • GotoDeskAndPage
  • Scroll

Don't forget to update hard-coded instances of these in modules:

  • FvwmButtons
  • FvwmPager
@ThomasAdam ThomasAdam added the type:breaking Issue is not backwards-compatible and will break configs/build label Mar 20, 2024
@ThomasAdam ThomasAdam added this to the 1.1.0 milestone Mar 20, 2024
@ThomasAdam ThomasAdam self-assigned this Mar 20, 2024
@ThomasAdam ThomasAdam added this to FVWM3 Mar 20, 2024
@github-project-automation github-project-automation bot moved this to To do in FVWM3 Mar 20, 2024
ThomasAdam added a commit that referenced this issue Mar 20, 2024
@ThomasAdam
Goto{Desk,Page,DeskAndPage}: use 'screen' keyword
068fe2c 
The GotoDesk, GotoPage, and GotoDeskAndPage commands have never followed
other conventions for commands which accept screen-specific
instructioons, by using the literal keyword "screen" to denote the
specific screen.

For example:

    EWMHBaseStruts screen HDMI-1 0 0 20 20

Change these commands so that this is the case.  This also includes
hard-coded references to commands used by modules, such as FvwmPager.

This is a breaking syntax change.

Fixes #965
@ThomasAdam ThomasAdam moved this from To do to PRs in FVWM3 Mar 20, 2024
@github-project-automation github-project-automation bot moved this from PRs to Done in FVWM3 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasAdam ThomasAdam

Labels
type:breaking Issue is not backwards-compatible and will break configs/build
Projects
FVWM3
Status: Done
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@ThomasAdam