Skip to content
This repository was archived by the owner on Apr 30, 2021. It is now read-only.

Commit 47ba2a2

Browse files
author
Yevgeny Pats
committed
bugfix in target create command
1 parent 1f30c2f commit 47ba2a2

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

client/commands.go

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,22 +73,28 @@ func (c *fuzzitClient) GetResource(resource string) error {
7373
}
7474
}
7575

76-
func (c *fuzzitClient) CreateTarget(targetConfig Target, seedPath string) (*firestore.DocumentRef, error) {
76+
func (c *fuzzitClient) CreateTarget(targetName string, seedPath string) (*firestore.DocumentRef, error) {
7777
ctx := context.Background()
78-
collectionRef := c.firestoreClient.Collection("orgs/" + c.Org + "/targets")
79-
doc, _, err := collectionRef.Add(ctx, targetConfig)
80-
if err != nil {
81-
return nil, err
78+
docRef := c.firestoreClient.Doc("orgs/" + c.Org + "/targets/" + targetName)
79+
_, err := docRef.Get(ctx)
80+
if err == nil {
81+
return nil, fmt.Errorf("target %s already exist", targetName)
8282
}
8383

8484
if seedPath != "" {
85-
storagePath := fmt.Sprintf("orgs/%s/targets/%s/seed", c.Org, doc.ID)
85+
storagePath := fmt.Sprintf("orgs/%s/targets/%s/seed", c.Org, targetName)
8686
err := c.uploadFile(seedPath, storagePath, "application/gzip", "seed.tar.gz")
8787
if err != nil {
8888
return nil, err
8989
}
9090
}
91-
return doc, nil
91+
92+
_, err = docRef.Set(ctx, Target{Name: targetName})
93+
if err != nil {
94+
return nil, err
95+
}
96+
97+
return docRef, nil
9298
}
9399

94100
func (c *fuzzitClient) CreateJob(jobConfig Job, files []string) (*firestore.DocumentRef, error) {

cmd/root.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var cfgFile string
2626
var rootCmd = &cobra.Command{
2727
Use: "Fuzzit",
2828
Short: "Continuous fuzzing made simple CLI",
29-
Version: "2.2.0",
29+
Version: "2.3.0",
3030
}
3131

3232
func Execute() {

cmd/target.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,12 @@ var targetCmd = &cobra.Command{
3232
if err != nil {
3333
log.Fatal(err)
3434
}
35-
newTarget := client.Target{
36-
Name: args[0],
37-
}
35+
3836
seed, err := cmd.Flags().GetString("seed")
3937
if err != nil {
4038
log.Fatal(err)
4139
}
42-
docRef, err := c.CreateTarget(newTarget, seed)
40+
docRef, err := c.CreateTarget(args[0], seed)
4341
if err != nil {
4442
log.Fatal(err)
4543
}

0 commit comments

Comments
 (0)