Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-basic doc need amending #76

Open
krisleech opened this issue Feb 23, 2018 · 1 comment
Open

http-basic doc need amending #76

krisleech opened this issue Feb 23, 2018 · 1 comment

Comments

@krisleech
Copy link

In the http-basic section it says to add (wrap-authentication), but it seems that (wrap-authorization) middleware is also needed.

Without this middleware no 'basic auth' dialog is shown to enter the username/password.

This caught me out because it didn't even occur to me that I needed to add "authorization" to do "authentication".

Thanks!

@terop
Copy link
Contributor

terop commented Oct 7, 2018

I created a PR to fix this issue: #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants