Skip to content

Commit f575e91

Browse files
authored
refactor: use slices.Contains to simplify code (#536)
Signed-off-by: vastonus <[email protected]>
1 parent ed672b2 commit f575e91

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

grpcurl.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import (
1717
"net"
1818
"os"
1919
"regexp"
20+
"slices"
2021
"sort"
2122
"strings"
2223

@@ -450,11 +451,9 @@ func makeTemplate(md *desc.MessageDescriptor, path []*desc.MessageDescriptor) pr
450451
dm := dynamic.NewMessage(md)
451452

452453
// if the message is a recursive structure, we don't want to blow the stack
453-
for _, seen := range path {
454-
if seen == md {
455-
// already visited this type; avoid infinite recursion
456-
return dm
457-
}
454+
if slices.Contains(path, md) {
455+
// already visited this type; avoid infinite recursion
456+
return dm
458457
}
459458
path = append(path, dm.GetMessageDescriptor())
460459

0 commit comments

Comments
 (0)