Skip to content

Commit 4fc38e6

Browse files
fix: preserve legacy skill category filters
1 parent 57c3294 commit 4fc38e6

8 files changed

Lines changed: 58 additions & 21 deletions

File tree

‎convex/skills.listPublicPageV4.test.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,13 +192,13 @@ describe("skills.listPublicPageV4", () => {
192192
it("keeps highlighted category listings on the highlighted path when official-first is enabled", async () => {
193193
const ctx = makeHighlightedCtx([
194194
makeDigest({
195-
id: "productivity",
196-
slug: "productivity-skill",
195+
id: "workflows",
196+
slug: "workflows-skill",
197197
stars: 1,
198198
installsAllTime: 1,
199199
downloads: 1,
200200
updatedAt: 200,
201-
primaryCategory: "productivity-tasks",
201+
primaryCategory: "automation-workflows",
202202
}),
203203
makeDigest({
204204
id: "development",
@@ -214,11 +214,11 @@ describe("skills.listPublicPageV4", () => {
214214
const result = await listPublicPageV4Handler(ctx, {
215215
highlightedOnly: true,
216216
officialFirst: true,
217-
categorySlug: "productivity-tasks",
217+
categorySlug: "workflows",
218218
numItems: 10,
219219
});
220220

221-
expect(result.page.map((entry) => entry.skill.slug)).toEqual(["productivity-skill"]);
221+
expect(result.page.map((entry) => entry.skill.slug)).toEqual(["workflows-skill"]);
222222
expect(ctx.db.query).toHaveBeenCalledWith("skillBadges");
223223
});
224224
});

‎convex/skills.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import {
33
isSkillCategorySlug,
44
normalizeCatalogTopic,
55
normalizeCatalogTopics,
6+
normalizeSkillCategorySlug,
67
normalizeTextContentType,
78
resolveSkillPrimaryCategory,
89
type SkillCategorySlug,
@@ -5484,8 +5485,7 @@ export const listPublicPageV4 = query({
54845485
type ServerSkillCategorySlug = SkillCategorySlug;
54855486

54865487
function normalizeRelatedCategorySlug(categorySlug: string | undefined) {
5487-
const value = categorySlug?.trim().toLowerCase();
5488-
return isSkillCategorySlug(value) ? value : null;
5488+
return normalizeSkillCategorySlug(categorySlug) ?? null;
54895489
}
54905490

54915491
function normalizeRelatedCategoryKeywords(keywords: string[]) {

‎packages/schema/dist/catalogMetadata.d.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ type SkillCategoryCandidate = {
101101
capabilityTags?: string[] | null;
102102
};
103103
export declare function isSkillCategorySlug(value: string | null | undefined): value is SkillCategorySlug;
104+
export declare function normalizeSkillCategorySlug(value: unknown): SkillCategorySlug | undefined;
104105
export declare function deriveSkillPrimaryCategory(skill: Omit<SkillCategoryCandidate, "primaryCategory">): SkillCategorySlug | undefined;
105106
export declare function resolveSkillPrimaryCategory(skill: SkillCategoryCandidate): SkillCategorySlug | undefined;
106107
export declare function resolveStoredSkillPrimaryCategory(skill: SkillCategoryCandidate): SkillCategorySlug | typeof INTERNAL_UNCATEGORIZED_CATEGORY;

‎packages/schema/dist/catalogMetadata.js‎

Lines changed: 17 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/schema/dist/catalogMetadata.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/schema/src/catalogMetadata.test.ts‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { describe, expect, it } from "vitest";
22
import {
33
CATALOG_TOPIC_LIMIT,
44
deriveSkillPrimaryCategory,
5+
normalizeSkillCategorySlug,
56
normalizeCatalogTopics,
67
normalizeInferredCatalogTopics,
78
resolvePublishedSkillPrimaryCategory,
@@ -47,6 +48,18 @@ describe("catalog metadata", () => {
4748
).toBe("security-review");
4849
});
4950

51+
it.each([
52+
["mcp-tools", "data-apis"],
53+
["prompts", "agent-behavior"],
54+
["workflows", "automation-workflows"],
55+
["data", "data-apis"],
56+
["security", "security-review"],
57+
["automation", "automation-workflows"],
58+
["other", "domain-utilities"],
59+
])("maps the legacy %s category slug to %s", (legacySlug, currentSlug) => {
60+
expect(normalizeSkillCategorySlug(legacySlug)).toBe(currentSlug);
61+
});
62+
5063
it("stores an internal uncategorized value when no public category matches", () => {
5164
expect(
5265
resolveStoredSkillPrimaryCategory({

0 commit comments

Comments
 (0)