Skip to content

Commit 902fd88

Browse files
committed
Added few comments
1 parent 9dd3f76 commit 902fd88

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

build.fsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -811,6 +811,7 @@ runtimes
811811
Configuration = DotNet.Release
812812
OutputPath = Some outDir
813813
Framework = Some "net6.0"
814+
// DisableInternalBinLog: https://github.com/fsprojects/FAKE/issues/2722
814815
MSBuildParams = { MSBuild.CliArguments.Create() with DisableInternalBinLog = true }}
815816
|> dotnetSimple)
816817
proj
@@ -879,6 +880,7 @@ Target.create "DotNetCreateNuGetPackage" (fun _ ->
879880
Properties =
880881
[ ("Version", nugetVersion)
881882
("PackageReleaseNotes", release.Notes |> String.toLines) ]
883+
// DisableInternalBinLog: https://github.com/fsprojects/FAKE/issues/2722
882884
DisableInternalBinLog = true } }
883885
|> dotnetSimple)
884886
"Fake.sln"

src/app/Fake.Runtime/CoreCache.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ let findAndLoadInRuntimeDeps
333333
let isFramework =
334334
assembly.GetCustomAttributes<AssemblyMetadataAttribute>()
335335
|> Seq.exists (fun m ->
336-
m.Key = ".NETFrameworkAssembly"
336+
m.Key = ".NETFrameworkAssembly" // net8.0 framework assemblies have NETFrameworkAssembly attribute removed. So identify them via RepositoryUrl:
337337
|| (m.Key = "RepositoryUrl" && m.Value.StartsWith "https://github.com/dotnet/"))
338338

339339
if not isFramework then

0 commit comments

Comments
 (0)