Skip to content

Commit e14de3f

Browse files
authored
Update to latest eslint-config-frontier-react (#12)
See fs-webdev/eslint-config-frontier-react#37
1 parent 1a9616a commit e14de3f

File tree

4 files changed

+14
-71
lines changed

4 files changed

+14
-71
lines changed

demo/test/snapshots/linting-config.test.js.md

+7-8
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,12 @@ Generated by [AVA](https://ava.li).
3838
"react-hooks",␊
3939
"import",␊
4040
"@babel",␊
41-
"json",␊
41+
"jsdoc",␊
4242
"you-dont-need-lodash-underscore",␊
4343
"prettier",␊
4444
"test-selectors",␊
4545
"sonarjs",␊
4646
"promise",␊
47-
"jsdoc",␊
4847
"html",␊
4948
"deprecate",␊
5049
"bestpractices"␊
@@ -65,6 +64,9 @@ Generated by [AVA](https://ava.li).
6564
"@babel/semi": [␊
6665
"off"␊
6766
],␊
67+
"@typescript-eslint/block-spacing": [␊
68+
"off"␊
69+
],␊
6870
"@typescript-eslint/brace-style": [␊
6971
"off"␊
7072
],␊
@@ -80,6 +82,9 @@ Generated by [AVA](https://ava.li).
8082
"@typescript-eslint/indent": [␊
8183
"off"␊
8284
],␊
85+
"@typescript-eslint/key-spacing": [␊
86+
"off"␊
87+
],␊
8388
"@typescript-eslint/keyword-spacing": [␊
8489
"off"␊
8590
],␊
@@ -713,12 +718,6 @@ Generated by [AVA](https://ava.li).
713718
"jsdoc/valid-types": [␊
714719
"warn"␊
715720
],␊
716-
"json/*": [␊
717-
"error",␊
718-
{␊
719-
"allowComments": true␊
720-
}␊
721-
],␊
722721
"jsx-a11y/accessible-emoji": [␊
723722
"off"␊
724723
],␊
-5 Bytes
Binary file not shown.

es6.js

+1-56
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ module.exports = {
1010
extends: [
1111
'@fs/eslint-config-frontier-react/es6',
1212
'@fs/eslint-config-frontier-react/json',
13+
'@fs/eslint-config-frontier-react/jsdoc',
1314
'@fs/eslint-config-frontier-react/dont-need-lodash',
1415
'@fs/eslint-config-frontier-react/typescript',
1516
'@fs/eslint-config-frontier-react/prettierSetup', // Always have prettier last so it can override format rules in the extends before it
@@ -18,7 +19,6 @@ module.exports = {
1819
'eslint-plugin-bestpractices',
1920
'eslint-plugin-deprecate',
2021
'eslint-plugin-html',
21-
'eslint-plugin-jsdoc',
2222
'eslint-plugin-promise',
2323
'eslint-plugin-sonarjs',
2424
'eslint-plugin-test-selectors',
@@ -94,61 +94,6 @@ module.exports = {
9494
// ]
9595
},
9696
overrides: [
97-
{
98-
files: ['*.js?(x)', '*.html'],
99-
rules: {
100-
'valid-jsdoc': ['warn'],
101-
// jsdoc/check-access
102-
'jsdoc/check-alignment': 'warn',
103-
// jsdoc/check-indentation
104-
// jsdoc/check-line-alignment
105-
'jsdoc/check-param-names': 'warn',
106-
// jsdoc/check-property-names
107-
'jsdoc/check-syntax': 'warn',
108-
'jsdoc/check-tag-names': 'warn',
109-
'jsdoc/check-types': 'warn',
110-
// jsdoc/check-values
111-
// jsdoc/empty-tags
112-
'jsdoc/implements-on-classes': 'warn',
113-
'jsdoc/match-description': 'warn',
114-
// jsdoc/match-name
115-
// jsdoc/multiline-blocks
116-
// jsdoc/newline-after-description
117-
// jsdoc/no-bad-blocks
118-
// jsdoc/no-defaults
119-
// jsdoc/no-missing-syntax
120-
// jsdoc/no-multi-asterisks
121-
// jsdoc/no-restricted-syntax
122-
// jsdoc/no-types
123-
// jsdoc/no-undefined-types - 2020-01-23: This was broken in eslint-plugin-jsdoc#8 in 2019-06, and hasn't gotten much better. Disabled, for now. Check back later.
124-
// jsdoc/require-asterisk-prefix
125-
// jsdoc/require-description-complete-sentence
126-
'jsdoc/require-description': 'warn',
127-
// jsdoc/require-example
128-
// jsdoc/require-file-overview
129-
'jsdoc/require-hyphen-before-param-description': 'warn',
130-
// jsdoc/require-jsdoc
131-
'jsdoc/require-param-description': 'warn',
132-
'jsdoc/require-param-name': 'warn',
133-
'jsdoc/require-param-type': 'warn',
134-
'jsdoc/require-param': 'warn',
135-
// 'jsdoc/require-property': 'warn',
136-
// 'jsdoc/require-property-description': 'warn',
137-
// 'jsdoc/require-property-name': 'warn',
138-
// 'jsdoc/require-property-type': 'warn'
139-
'jsdoc/require-returns-check': 'warn',
140-
'jsdoc/require-returns-description': 'warn',
141-
'jsdoc/require-returns-type': 'warn',
142-
'jsdoc/require-returns': 'warn',
143-
// jsdoc/require-throws
144-
// jsdoc/require-yields
145-
// jsdoc/require-yields-check
146-
// jsdoc/sort-tags
147-
// jsdoc/tag-lines
148-
// jsdoc/text-escaping
149-
'jsdoc/valid-types': 'warn',
150-
},
151-
},
15297
{
15398
files: ['*.stories.*', '*test*', '**/test/**', '**/*mock*/**', '*mock*', '**/setupTests.*'],
15499
extends: ['@fs/eslint-config-frontier-react/jest'],

package.json

+6-7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "eslint-config-tree",
3-
"version": "6.0.0-alpha.0",
3+
"version": "6.0.0-alpha.1",
44
"description": "Shared Tree configuration that contains overrides and enhancements on top of the base frontier configuration.",
55
"main": "index.js",
66
"repository": {
@@ -28,7 +28,6 @@
2828
"eslint-plugin-bestpractices": "github:skye2k2/eslint-plugin-bestpractices",
2929
"eslint-plugin-deprecate": "^0.7.0",
3030
"eslint-plugin-html": "^7.1.0",
31-
"eslint-plugin-jsdoc": "^40.0.0",
3231
"eslint-plugin-promise": "^6.1.1",
3332
"eslint-plugin-sonarjs": "^0.18.0",
3433
"eslint-plugin-test-selectors": "^2.0.4"
@@ -44,11 +43,11 @@
4443
}
4544
},
4645
"scripts": {
47-
"lint": "eslint demo --ext .html,.js,.json",
48-
"lint:fix": "eslint demo --ext .html,.js,.json --fix",
49-
"lint:quiet": "eslint demo --ext .html,.js,.json --quiet",
50-
"lint:report": "eslint demo --ext .html,.js,.json '**/*.html' --format html --output-file ./reports/linting/linting_report.html & eslint demo --ext .html,.js,.json --format json --output-file ./reports/linting/linting_report.json",
51-
"lint:snapshot": "eslint demo --ext .html,.js,.json --no-color --output-file ./demo/test/snapshots/local-linting-output.txt; eslint --print-config file.js > ./demo/test/snapshots/local-linting-final-config.json; npm run test:format",
46+
"lint": "eslint demo",
47+
"lint:fix": "eslint demo --fix",
48+
"lint:quiet": "eslint demo --quiet",
49+
"lint:report": "eslint demo '**/*.html' --format html --output-file ./reports/linting/linting_report.html & eslint demo --format json --output-file ./reports/linting/linting_report.json",
50+
"lint:snapshot": "eslint demo --no-color --output-file ./demo/test/snapshots/local-linting-output.txt; eslint --print-config file.js > ./demo/test/snapshots/local-linting-final-config.json; npm run test:format",
5251
"preinstall": "git config --global url.https://github.com/.insteadOf git://github.com/",
5352
"postinstall": "npm rebuild husky",
5453
"test": "npm run lint:snapshot; ava",

0 commit comments

Comments
 (0)