Skip to content

Commit e126b72

Browse files
authored
UpdateQALintingRules (#19)
QA uses WDIO, and with some of the ways WDIO is formatted, we use unnamed functions as our `it` functions. We CAN use arrow functions, but that kills the ability to use `this` in our tests. Which we use a lot.
1 parent c679cb5 commit e126b72

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@fs/eslint-config-tree",
3-
"version": "6.0.0",
3+
"version": "6.0.1",
44
"description": "Shared Tree configuration that contains overrides and enhancements on top of the base frontier configuration.",
55
"main": "index.js",
66
"repository": {

qa.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ module.exports = {
1818
'import/no-extraneous-dependencies': ['error', { 'devDependencies': true }],
1919
'testing-library/no-await-sync-query': 'off', // All @testing-library/webdriverio queries are async (https://testing-library.com/docs/webdriverio-testing-library/intro/)
2020
'testing-library/prefer-screen-queries': 'off', // We use browser instead of screen for @testing-library/webdriverio
21-
'@babel/no-unused-expressions': 'off' // to allow expressions like this: tree.expect(await (await $(tree.MBTpageObjects.getBCButton())).isDisplayed()).to.be.true
21+
'@babel/no-unused-expressions': 'off', // to allow expressions like this: tree.expect(await (await $(tree.MBTpageObjects.getBCButton())).isDisplayed()).to.be.true
22+
'func-names': 'off' // to allow for how WDIO does "it" functions: "it('Login', async function () {". We need "this" and we can keep "this" by using "unnamed async function"
2223
}
2324
}
2425
]

0 commit comments

Comments
 (0)