Skip to content

Commit 75610f0

Browse files
authored
Consume cypress rules from eslint-frontier-react-config/cypress (#23)
1. npm update 2. add frontier's cypress config for our es6 config so we can have that for our apps without specifying it in our apps. The cypress linting rules are specific to just cypress tests. 3. update tests
1 parent 082391b commit 75610f0

File tree

4 files changed

+20
-4
lines changed

4 files changed

+20
-4
lines changed

demo/test/snapshots/linting-config.test.js.md

+15
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Generated by [AVA](https://ava.li).
1010
1111
`{␊
1212
"env": {␊
13+
"cypress/globals": true,␊
1314
"jest/globals": true,␊
1415
"es2021": true,␊
1516
"es6": true,␊
@@ -43,6 +44,7 @@ Generated by [AVA](https://ava.li).
4344
"@fs/zion",␊
4445
"jest",␊
4546
"you-dont-need-lodash-underscore",␊
47+
"cypress",␊
4648
"prettier",␊
4749
"test-selectors",␊
4850
"sonarjs",␊
@@ -292,6 +294,18 @@ Generated by [AVA](https://ava.li).
292294
0,␊
293295
"multi-line"␊
294296
],␊
297+
"cypress/no-assigning-return-values": [␊
298+
"error"␊
299+
],␊
300+
"cypress/no-async-tests": [␊
301+
"error"␊
302+
],␊
303+
"cypress/no-unnecessary-waiting": [␊
304+
"error"␊
305+
],␊
306+
"cypress/unsafe-to-chain-command": [␊
307+
"error"␊
308+
],␊
295309
"default-case": [␊
296310
"error",␊
297311
{␊
@@ -621,6 +635,7 @@ Generated by [AVA](https://ava.li).
621635
]␊
622636
],␊
623637
"distinctGroup": true,␊
638+
"named": false,␊
624639
"warnOnUnassignedImports": false␊
625640
}␊
626641
],␊
71 Bytes
Binary file not shown.

es6.js

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ module.exports = {
1414
'@fs/eslint-config-frontier-react/jest',
1515
'@fs/eslint-config-frontier-react/dont-need-lodash',
1616
'@fs/eslint-config-frontier-react/typescript',
17+
'@fs/eslint-config-frontier-react/cypress',
1718
'@fs/eslint-config-frontier-react/prettierSetup', // Always have prettier last so it can override format rules in the extends before it
1819
],
1920
plugins: [

package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@fs/eslint-config-tree",
3-
"version": "6.1.1",
3+
"version": "6.2.0",
44
"description": "Shared Tree configuration that contains overrides and enhancements on top of the base frontier configuration.",
55
"main": "index.js",
66
"repository": {
@@ -28,8 +28,8 @@
2828
"!.*"
2929
],
3030
"dependencies": {
31-
"@babel/eslint-parser": "^7.25.1",
32-
"@fs/eslint-config-frontier-react": "^11.2.0",
31+
"@babel/eslint-parser": "^7.26.10",
32+
"@fs/eslint-config-frontier-react": "^11.2.2",
3333
"eslint": "^8.57.1",
3434
"eslint-plugin-bestpractices": "github:skye2k2/eslint-plugin-bestpractices",
3535
"eslint-plugin-deprecate": "^0.7.0",
@@ -42,7 +42,7 @@
4242
"@fs/npm-publisher": "^1.6.0",
4343
"ava": "^2.4.0",
4444
"file-manager-js": "^3.1.6",
45-
"husky": "^9.1.6"
45+
"husky": "^9.1.7"
4646
},
4747
"scripts": {
4848
"lint": "eslint demo",

0 commit comments

Comments
 (0)