Skip to content

Commit ab03e7e

Browse files
authored
Merge pull request #348 from fs-webdev/dontFailEslintWarnings
dont fail build script when CI=true for eslint warnings
2 parents cbcd486 + 05578e1 commit ab03e7e

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

CHANGELOG-FRONTIER.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 8.5.2
2+
3+
- Ignore eslint warnings during the `build` script
4+
15
## 8.5.1
26

37
- Updated coalesce-locale script to handle if a zion dep is only nested, and not flattened to node_modules/@fs/

packages/react-scripts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@fs/react-scripts",
3-
"version": "8.5.1",
3+
"version": "8.5.2",
44
"upstreamVersion": "5.0.1",
55
"description": "Configuration and scripts for Create React App.",
66
"repository": {

packages/react-scripts/scripts/build.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,9 @@ function build(previousFileSizes) {
185185
messages.warnings.length
186186
) {
187187
// Ignore sourcemap warnings in CI builds. See #8227 for more info.
188+
// Frontier Ignore eslint warnings as well
188189
const filteredWarnings = messages.warnings.filter(
189-
w => !/Failed to parse source map/.test(w)
190+
w => !/Failed to parse source map/.test(w) && !/\[eslint\]/.test(w)
190191
);
191192
if (filteredWarnings.length) {
192193
console.log(

0 commit comments

Comments
 (0)