Skip to content

Commit 5e017e9

Browse files
committed
Updating comments in custom Modernizr tests
1 parent 25c2896 commit 5e017e9

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

packages/react-scripts/layout/views/partials/featureDetection.ejs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
if (Modernizr) {
22
const unsupportedBrowserHeader = document.getElementById('unsupported-browser');
33

4+
<%# Handles Chrome/Edge v84 and lower %>
45
Modernizr.addTest('replaceAll', () => {
56
return typeof String.prototype.replaceAll === 'function';
67
});
78

9+
<%# Handles Firefox v90/Safari v15 and lower %>
10+
<%# Written with eval because declaring a function with private class fields threw an error outside of the catch %>
811
Modernizr.addTest('privateFields', () => {
912
try {
1013
eval("class Test { #privateField; }");
@@ -14,10 +17,8 @@ if (Modernizr) {
1417
}
1518
});
1619
17-
const outdatedFeatures = Object.keys(Modernizr).filter(feature => !Modernizr[feature]);
18-
1920
if (unsupportedBrowserHeader) {
20-
if (outdatedFeatures.length > 0) {
21+
if (Object.keys(Modernizr).filter(feature => !Modernizr[feature]).length > 0) {
2122
unsupportedBrowserHeader.style.display = 'block';
2223
} else {
2324
unsupportedBrowserHeader.remove();

0 commit comments

Comments
 (0)