Modify Hook trait to pass RequestId by value instead of reference

- Update `Hook` trait method signature to take `RequestId` by value
- Adjust implementations and usages in `lib.rs` and `tests/session.rs`
- Remove unnecessary reference passing for `RequestId`

Author: frozenlib

src/lib.rs

@@ -53,10 +53,10 @@ pub trait Handler {
 impl Handler for () {}
 
 pub trait Hook: Send + Sync {
-    fn cancel_outgoing_request(&self, id: &RequestId, session: &SessionContext);
+    fn cancel_outgoing_request(&self, id: RequestId, session: &SessionContext);
 }
 impl Hook for () {
-    fn cancel_outgoing_request(&self, _id: &RequestId, _session: &SessionContext) {}
+    fn cancel_outgoing_request(&self, _id: RequestId, _session: &SessionContext) {}
 }
 
 pub const NO_PARAMS: Option<&()> = None;
@@ -849,7 +849,7 @@ impl RawSession {
         while self.fetch_outgoing_cancellations(&mut id_reader).await {
             let session_ctx = SessionContext::new(self);
             for id in &mut id_reader {
-                self.hook.cancel_outgoing_request(&id.into(), &session_ctx);
+                self.hook.cancel_outgoing_request(id.into(), &session_ctx);
             }
         }
         Ok(())

tests/session.rs

@@ -2,8 +2,8 @@ use std::{sync::Arc, time::Duration};
 
 use assert_call::{call, Call, CallRecorder};
 use jsoncall::{
-    ErrorCode, ErrorObject, Handler, Hook, NotificationContext, Params, RequestContext, Response,
-    Result, Session, SessionContext, SessionError, SessionErrorKind, NO_PARAMS,
+    ErrorCode, ErrorObject, Handler, Hook, NotificationContext, Params, RequestContext, RequestId,
+    Response, Result, Session, SessionContext, SessionError, SessionErrorKind, NO_PARAMS,
 };
 use serde::{Deserialize, Serialize};
 use tokio::{
@@ -528,9 +528,9 @@ impl Handler for HelloService {
     fn hook(&self) -> Arc<dyn jsoncall::Hook> {
         struct TestHook;
         impl Hook for TestHook {
-            fn cancel_outgoing_request(&self, id: &jsoncall::RequestId, session: &SessionContext) {
+            fn cancel_outgoing_request(&self, id: RequestId, session: &SessionContext) {
                 call!("cancel_outgoing_request");
-                let _ = session.notification("cancel", Some(id));
+                let _ = session.notification("cancel", Some(&id));
             }
         }
 
@@ -643,7 +643,7 @@ impl Handler for HelloService {
             "notify" => cx.handle(this.notify(params.to()?)),
             "notify_async" => cx.handle_async(this.notify_async(params.to()?)),
             "cancel" => {
-                let request_id: jsoncall::RequestId = params.to()?;
+                let request_id: RequestId = params.to()?;
                 cx.session().cancel_incoming_request(&request_id, None);
                 cx.handle(Ok(()))
             }