Skip to content

Commit 216888e

Browse files
committed
Make the code conform to PEP8
1 parent 0d1260c commit 216888e

File tree

9 files changed

+385
-334
lines changed

9 files changed

+385
-334
lines changed

main.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
from pybot.data_container import Data_container
55
import time
66

7-
plugin_manager.load_plugins ()
7+
plugin_manager.load_plugins()
88

9-
servers = configuration.get ( "servers" )
9+
servers = configuration.get("servers")
1010
for server_config in servers:
11-
handle = Data_container ( server_config )
12-
server = irc.Irc_server ( handle )
13-
server.start ()
11+
handle = Data_container(server_config)
12+
server = irc.Irc_server(handle)
13+
server.start()
1414

1515
while True:
1616
# Keep thread alive
17-
time.sleep ( 1 )
17+
time.sleep(1)

pybot/configuration.py

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@
55

66
_config_container = None
77

8-
class Configuration_data_container ( object ):
9-
def __init__ ( self, filename ):
8+
9+
class Configuration_data_container (object):
10+
11+
def __init__(self, filename):
1012
"""Create a Configuration_data_container from a filename."""
1113

12-
self._container = Persistent_data_container ( filename )
14+
self._container = Persistent_data_container(filename)
1315

14-
def get ( self, key ):
16+
def get(self, key):
1517
"""Return a value or None if not set
1618
1719
Keys:
@@ -21,18 +23,18 @@ def get ( self, key ):
2123
"""
2224

2325
# Simply return value from self._container
24-
return self._container.get ( key )
26+
return self._container.get(key)
2527

26-
def get_data ( self ):
28+
def get_data(self):
2729
"""Return a deepcopy of the wrapped data.
2830
2931
This method is thread safe.
3032
"""
3133

3234
# Simply return value from self._container
33-
return self._container.get_data ()
35+
return self._container.get_data()
3436

35-
def get_data_container ( self, key ):
37+
def get_data_container(self, key):
3638
"""Return a Data_container object representing a dict identified by a key.
3739
3840
Keys:
@@ -42,9 +44,10 @@ def get_data_container ( self, key ):
4244
"""
4345

4446
# Simply return value from self._container
45-
return self._container.get_data_container ( key )
47+
return self._container.get_data_container(key)
4648

47-
def get ( key ):
49+
50+
def get(key):
4851
"""Return a configuration value or None if not set
4952
5053
Keys:
@@ -54,9 +57,10 @@ def get ( key ):
5457
"""
5558

5659
# Simply call the method in _config_container
57-
return _config_container.get ( key )
60+
return _config_container.get(key)
61+
5862

59-
def get_data_container ( key ):
63+
def get_data_container(key):
6064
"""Return a Data_container object representing a dict identified by a key.
6165
6266
Keys:
@@ -65,8 +69,9 @@ def get_data_container ( key ):
6569
This method is thread safe.
6670
"""
6771

68-
return _config_container.get_data_container ( key )
72+
return _config_container.get_data_container(key)
6973

7074
# Initialize configuration
7175
if _config_container == None:
72-
_config_container = Configuration_data_container ( os.path.dirname ( __file__ ) + "/../config.json" )
76+
_config_container = Configuration_data_container(
77+
os.path.dirname(__file__) + "/../config.json")

pybot/data_container.py

Lines changed: 64 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,22 @@
44
import log
55
import json
66

7-
class Data_container ( object ):
8-
def __init__ ( self, data ):
7+
8+
class Data_container (object):
9+
10+
def __init__(self, data):
911
"""Create a Data_container from a dict."""
1012

1113
# Data_container will only represent dicts
12-
if not type ( data ) == dict:
13-
log.write ( "Error in data_container: data is not a dict" )
14-
raise ValueError ( "Error: data is not a dict" )
14+
if not type(data) == dict:
15+
log.write("Error in data_container: data is not a dict")
16+
raise ValueError("Error: data is not a dict")
1517

1618
# Always use deepcopy to make it thread safe
17-
self._data = copy.deepcopy ( data )
18-
self._lock = threading.Lock ()
19+
self._data = copy.deepcopy(data)
20+
self._lock = threading.Lock()
1921

20-
def get ( self, key ):
22+
def get(self, key):
2123
"""Return a value or None if not set
2224
2325
Keys:
@@ -27,25 +29,25 @@ def get ( self, key ):
2729
"""
2830

2931
with self._lock:
30-
key_levels = key.split ( "." )
32+
key_levels = key.split(".")
3133
position = self._data
3234

3335
for key_level in key_levels:
3436
# Check the current type, so the type of the last iteration's position isn't
3537
# checked. This will allow getting non-dict values.
36-
if type ( position ) == dict:
38+
if type(position) == dict:
3739
if key_level in position:
3840
# Set position to next dict in "tree"
39-
position = position [ key_level ]
41+
position = position[key_level]
4042
continue
4143

4244
# Return None if either one doesn't apply
4345
return None
4446

4547
# Always use deepcopy to make it thread safe
46-
return copy.deepcopy ( position )
48+
return copy.deepcopy(position)
4749

48-
def append ( self, key, value ):
50+
def append(self, key, value):
4951
"""Append a value to a list responding to a key.
5052
5153
Keys:
@@ -55,28 +57,30 @@ def append ( self, key, value ):
5557
"""
5658

5759
with self._lock:
58-
key_levels = key.split ( "." )
60+
key_levels = key.split(".")
5961
position = self._data
6062

6163
for key_level in key_levels:
6264
# Check the current type, so the type of the last iteration's position isn't
6365
# checked. This will allow getting non-dict values.
64-
if type ( position ) == dict:
66+
if type(position) == dict:
6567
if key_level in position:
6668
# Set position to next dict in "tree"
67-
position = position [ key_level ]
69+
position = position[key_level]
6870
continue
6971

70-
log.write ( "Error in data_container: Invalid key: %s" % key )
71-
raise ValueError ( "Error: Invalid key: %s" % key )
72+
log.write("Error in data_container: Invalid key: %s" % key)
73+
raise ValueError("Error: Invalid key: %s" % key)
7274

73-
if not type ( position ) == list:
74-
log.write ( "Error in data_container: Cannot append to %s ( %s ), has to be a list" % type ( position ), key )
75-
raise ValueError ( "Error: Cannot append to %s ( %s ), has to be a list" % type ( position ), key )
75+
if not type(position) == list:
76+
log.write("Error in data_container: Cannot append to %s ( %s ), has to be a list" % type(
77+
position), key)
78+
raise ValueError(
79+
"Error: Cannot append to %s ( %s ), has to be a list" % type(position), key)
7680

77-
position.append ( value )
81+
position.append(value)
7882

79-
def pop ( self, key, index ):
83+
def pop(self, key, index):
8084
"""Pop the value at an index off a list responding to a key.
8185
8286
Keys:
@@ -86,28 +90,30 @@ def pop ( self, key, index ):
8690
"""
8791

8892
with self._lock:
89-
key_levels = key.split ( "." )
93+
key_levels = key.split(".")
9094
position = self._data
9195

9296
for key_level in key_levels:
9397
# Check the current type, so the type of the last iteration's position isn't
9498
# checked. This will allow getting non-dict values.
95-
if type ( position ) == dict:
99+
if type(position) == dict:
96100
if key_level in position:
97101
# Set position to next dict in "tree"
98-
position = position [ key_level ]
102+
position = position[key_level]
99103
continue
100104

101-
log.write ( "Error in data_container: Invalid key: %s" % key )
102-
raise ValueError ( "Error: Invalid key: %s" % key )
105+
log.write("Error in data_container: Invalid key: %s" % key)
106+
raise ValueError("Error: Invalid key: %s" % key)
103107

104-
if not type ( position ) == list:
105-
log.write ( "Error in data_container: Cannot pop from %s ( %s ), has to be a list" % type ( position ), key )
106-
raise ValueError ( "Error: Cannot pop from %s ( %s ), has to be a list" % type ( position ), key )
108+
if not type(position) == list:
109+
log.write("Error in data_container: Cannot pop from %s ( %s ), has to be a list" % type(
110+
position), key)
111+
raise ValueError(
112+
"Error: Cannot pop from %s ( %s ), has to be a list" % type(position), key)
107113

108-
position.pop ( index )
114+
position.pop(index)
109115

110-
def remove ( self, key, value ):
116+
def remove(self, key, value):
111117
"""Remove a value from a list responding to a key.
112118
113119
Keys:
@@ -117,28 +123,30 @@ def remove ( self, key, value ):
117123
"""
118124

119125
with self._lock:
120-
key_levels = key.split ( "." )
126+
key_levels = key.split(".")
121127
position = self._data
122128

123129
for key_level in key_levels:
124130
# Check the current type, so the type of the last iteration's position isn't
125131
# checked. This will allow getting non-dict values.
126-
if type ( position ) == dict:
132+
if type(position) == dict:
127133
if key_level in position:
128134
# Set position to next dict in "tree"
129-
position = position [ key_level ]
135+
position = position[key_level]
130136
continue
131137

132-
log.write ( "Error in data_container: Invalid key: %s" % key )
133-
raise ValueError ( "Error: Invalid key: %s" % key )
138+
log.write("Error in data_container: Invalid key: %s" % key)
139+
raise ValueError("Error: Invalid key: %s" % key)
134140

135-
if not type ( position ) == list:
136-
log.write ( "Error in data_container: Cannot remove from %s ( %s ), has to be a list" % type ( position ), key )
137-
raise ValueError ( "Error: Cannot remove from %s ( %s ), has to be a list" % type ( position ), key )
141+
if not type(position) == list:
142+
log.write("Error in data_container: Cannot remove from %s ( %s ), has to be a list" % type(
143+
position), key)
144+
raise ValueError(
145+
"Error: Cannot remove from %s ( %s ), has to be a list" % type(position), key)
138146

139-
position.remove ( value )
147+
position.remove(value)
140148

141-
def set ( self, key, value ):
149+
def set(self, key, value):
142150
"""Set a value.
143151
144152
Keys:
@@ -148,40 +156,40 @@ def set ( self, key, value ):
148156
"""
149157

150158
with self._lock:
151-
key_levels = key.split ( "." )
159+
key_levels = key.split(".")
152160
position = self._data
153161

154162
# Ommit the last key_level from the iteration so position is the dict we want
155163
# to save the value in.
156-
for key_level in key_levels [ : -1 ]:
157-
if type ( position ) == dict:
164+
for key_level in key_levels[: -1]:
165+
if type(position) == dict:
158166
if key_level in position:
159167
# Set position to the nex position
160-
position = position [ key_level ]
168+
position = position[key_level]
161169

162170
# Create silently dict if it doesn't exist
163171
else:
164-
position [ key_level ] = {}
165-
position = position [ key_level ]
172+
position[key_level] = {}
173+
position = position[key_level]
166174

167175
else:
168-
log.write ( "Error in data_container: Invalid key: %s" % key )
169-
raise ValueError ( "Error: Invalid key: %s" % key )
176+
log.write("Error in data_container: Invalid key: %s" % key)
177+
raise ValueError("Error: Invalid key: %s" % key)
170178

171179
# Actually set the value
172-
position [ key_levels [ -1 ] ] = value
180+
position[key_levels[-1]] = value
173181

174-
def get_data ( self ):
182+
def get_data(self):
175183
"""Return a deepcopy of the wrapped data.
176184
177185
This method is thread safe.
178186
"""
179187

180188
with self._lock:
181189
# Always use deepcopy to make it thread safe
182-
return copy.deepcopy ( self._data )
190+
return copy.deepcopy(self._data)
183191

184-
def get_data_container ( self, key ):
192+
def get_data_container(self, key):
185193
"""Return a Data_container object representing a dict identified by a key.
186194
187195
Keys:
@@ -192,5 +200,4 @@ def get_data_container ( self, key ):
192200

193201
# The locking is already being done in self.get
194202
# Locking here as well would only cause a deadlock
195-
return Data_container ( self.get ( key ) )
196-
203+
return Data_container(self.get(key))

0 commit comments

Comments
 (0)