Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git auth/config is not respected #65

Closed
ordian opened this issue Sep 24, 2021 · 5 comments
Closed

git auth/config is not respected #65

ordian opened this issue Sep 24, 2021 · 5 comments

Comments

@ordian
Copy link

ordian commented Sep 24, 2021

See rust-lang/cargo#5914 for the reference.

This causes killercup/cargo-edit#515.
@ordian ordian mentioned this issue Sep 24, 2021
Closed
@kornelski
Copy link
Collaborator

This is a problem of the git2 crate: rust-lang/git2-rs#600

@epage
Copy link
Contributor

epage commented Sep 24, 2021

Looks like cargo handles that in src/cargo/sources/git/utils.rs in with_authentication

@epage
Copy link
Contributor

epage commented Sep 24, 2021

Please re-open this.

  • Looking at the linked issue, that issue is not any specific crate's fault but a question of where the logic should live
  • Regardless of the implementation details, this is impacting end-users of this crate and and is a defect against this crate.

@kornelski
Copy link
Collaborator

It's also a dupe of #37

@epage
Copy link
Contributor

epage commented Sep 24, 2021

Since this was closed, I split out the config part as #66

@epage epage mentioned this issue Oct 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@epage @kornelski @ordian