Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or remove vendor folder #27

Closed
breml opened this issue Aug 21, 2019 · 2 comments · Fixed by #28
Closed

Update or remove vendor folder #27

breml opened this issue Aug 21, 2019 · 2 comments · Fixed by #28

Comments

@breml
Copy link
Contributor

breml commented Aug 21, 2019

When I run GO111MODULE=on go mod vendor a lot of packages get updated in the vendor folder so I suggest to either commit an updated version of the vendor folder or remove it completely.

@frapposelli
Copy link
Owner

thanks for the heads up!, looks like I forgot to re-vendor the dependencies I changed yesterday and the binaries for 0.2.3 got built with the old vendor folder, not picking up the new packages.

I've just cut 0.2.4 and should be available as soon as CI finishes.

@breml
Copy link
Contributor Author

breml commented Aug 21, 2019

@frapposelli thanks for your swift feedback and the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants