Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-license dependency #25

Closed
breml opened this issue Aug 20, 2019 · 3 comments
Closed

Update go-license dependency #25

breml opened this issue Aug 20, 2019 · 3 comments

Comments

@breml
Copy link
Contributor

breml commented Aug 20, 2019

The current version of wwhrd does not recognize the license file in godotenv, because the license file is called LICENCE (British-English), see joho/godotenv#78.

After digging into the issue I found out, that wwhrd uses a out dated version of go-license. The latest version of this library also accepts the British version of the license file name (see: https://github.com/ryanuber/go-license/blob/master/license.go#L40).

It would be nice, if wwhrd could be updated to use the newest version of go-license.

I offer to provide a PR for this, but I was not able to find out, what you are using to manage the vendor/ folder. Maybe this is the time to switch to Go modules and solve #22 at the same time. I can help with that as well.

@frapposelli
Copy link
Owner

Very good point, I'll make the necessary changes to fix this.

@frapposelli
Copy link
Owner

Version v0.2.2 is now available 😄

@breml
Copy link
Contributor Author

breml commented Aug 20, 2019

@frapposelli Thank you very much for your fast fix, I will give it a try tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants