Commit ff01dbf
committed
fix(e2b): count and warn on malformed porcelain records (#967)
Both reviewers caught the same leftover: `_parse_porcelain`'s `rejected`
counter was never incremented. Deleting the C-unquoter removed the only
thing that incremented it, and I left the variable and its docstring
claim behind — so a malformed record was silently dropped, contradicting
this PR's own "never silently dropped" framing for AC2.
Real git cannot emit a record that isn't "XY PATH", so a malformed one
means the sandbox's git is not git — precisely the case worth surfacing.
Now warned, counted, and folded into the count emitted to the user
alongside containment rejections.1 parent 3ea1c11 commit ff01dbf
2 files changed
Lines changed: 35 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
396 | 396 | | |
397 | 397 | | |
398 | 398 | | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
399 | 403 | | |
400 | 404 | | |
401 | 405 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
248 | 279 | | |
249 | 280 | | |
250 | 281 | | |
| |||
0 commit comments