Merge pull request opnsense#4654 from fraenki/turn_1_1

net/turnserver: release 1.1

Author: fraenki

net/turnserver/Makefile

@@ -1,5 +1,5 @@
 PLUGIN_NAME=		turnserver
-PLUGIN_VERSION=		1.0
+PLUGIN_VERSION=		1.1
 PLUGIN_COMMENT=		The coturn STUN/TURN Server
 PLUGIN_DEPENDS=		turnserver
 PLUGIN_MAINTAINER=	[email protected]

net/turnserver/pkg-descr

@@ -2,3 +2,19 @@ Coturn is a free open source implementation of TURN and STUN Server.
 The TURN Server is a VoIP media traffic NAT traversal server and gateway.
 
 WWW: https://github.com/coturn/coturn
+
+1.1
+
+Added:
+* add log page
+
+Changed:
+* hide protocol violating options
+* switch to local syslog logging
+
+Removed:
+* remove old log files
+
+1.0
+
+Initial release

net/turnserver/src/opnsense/mvc/app/controllers/OPNsense/Turnserver/forms/settings.xml

@@ -116,12 +116,14 @@
         <id>turnserver.settings.ChannelLifetime</id>
         <label>Channel Lifetime</label>
         <type>text</type>
-        <help>The lifetime for the channel (in seconds). Default value is 600 secs (10 minutes).</help>
+        <help>The lifetime for the channel in seconds. Default value is 600 seconds (10 minutes). Changing this value violates RFC 5766. Use with care.</help>
+        <advanced>true</advanced>
     </field>
     <field>
         <id>turnserver.settings.PermissionLifetime</id>
         <label>Permission Lifetime</label>
         <type>text</type>
-        <help>The permission lifetime (in seconds). Default value is 300 secs (5 minutes).</help>
+        <help>The permission lifetime in seconds. Default value is 300 seconds (5 minutes). Changing this value violates RFC 5766. Use with care.</help>
+        <advanced>true</advanced>
     </field>
 </form>

net/turnserver/src/opnsense/mvc/app/models/OPNsense/Turnserver/ACL/ACL.xml

@@ -4,6 +4,8 @@
         <patterns>
             <pattern>ui/turnserver</pattern>
             <pattern>api/turnserver/*</pattern>
+            <pattern>ui/diagnostics/log/core/turnserver/*</pattern>
+            <pattern>api/diagnostics/log/core/turnserver/*</pattern>
         </patterns>
     </page-services-turnserver>
 </acl>

net/turnserver/src/opnsense/mvc/app/models/OPNsense/Turnserver/Menu/Menu.xml

@@ -1,5 +1,8 @@
 <menu>
     <Services>
-        <Turnserver cssClass="fa fa-comment-o fa-fw" url="/ui/turnserver"/>
+        <Turnserver cssClass="fa fa-comment-o fa-fw">
+            <Settings order="10" url="/ui/turnserver"/>
+            <Log VisibleName="Log File" order="40" url="/ui/diagnostics/log/core/turnserver"/>
+        </Turnserver>
     </Services>
 </menu>

net/turnserver/src/opnsense/scripts/OPNsense/Turnserver/export_certs.php

@@ -59,3 +59,12 @@
         }
     }
 }
+
+# Purge obsolete log files.
+# TODO: Should be removed in plugin version 2.0.
+$log_files = glob('/var/log/turn_*.log');
+foreach ($log_files as $file) {
+    if (is_file($file)) {
+        unlink($file);
+    }
+}

net/turnserver/src/opnsense/service/templates/OPNsense/Syslog/local/turnserver.conf

@@ -0,0 +1,6 @@
+###################################################################
+# Local syslog-ng configuration filter definition [turnserver].
+###################################################################
+filter f_local_turnserver {
+    program("turnserver");
+};

net/turnserver/src/opnsense/service/templates/OPNsense/Turnserver/turnserver.conf

@@ -50,6 +50,7 @@ channel-lifetime={{ OPNsense.turnserver.settings.ChannelLifetime }}
 permission-lifetime={{ OPNsense.turnserver.settings.PermissionLifetime }}
 
 # Defaults
+log-file=syslog
 no-cli
 no-software-attribute
 no-multicast-peers