Skip to content

feat(wallets): reuse session_id across multiple TrezorSigner #9388

New issue
New issue
Open
#10822
Open
feat(wallets): reuse session_id across multiple TrezorSigner#9388
#10822
Labels
C-forgeCommand: forgeCmd-forge-scriptCommand: forge scriptfirst issueA good way to start contributing
@joshieDo

Description

@joshieDo
joshieDo
opened on Nov 23, 2024

Component

Forge

Describe the feature you would like

foundry/crates/wallets/src/multi_wallet.rs

Lines 369 to 375 in 398ef4a

pub async fn trezors(&self) -> Result<Option<Vec<WalletSigner>>> {
if self.trezor {
create_hw_wallets!(self, utils::create_trezor_signer, wallets);
return Ok(Some(wallets));
}
Ok(None)
}

Currently, every new instance of TrezorSigner is created with their own session_id. If a passphrase is enabled on the device, it means requesting it for every mnemonic index.

Ideally, each TrezorSigner reuses the first created session_id.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-forgeCommand: forgeCmd-forge-scriptCommand: forge scriptfirst issueA good way to start contributing

    Type

    No type

    Projects

    Foundry

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions