Apply suggestions from code review

Co-authored-by: Evaline Ju <[email protected]>
Signed-off-by: Gaurav Kumbhat <[email protected]>

Author: gkumbhat

vllm_detector_adapter/generative_detectors/base.py

@@ -115,8 +115,8 @@ def preprocess_request(  # noqa: F811
     @detector_dispatcher(types=[DetectorType.TEXT_CONTENT])
     def preprocess_request(  # noqa: F811
         self, request: ContentsDetectionRequest
-    ) -> Union[ContentsDetectionRequest, ErrorResponse]:
-        """Preprocess contents request and convert it into appropriate chat request"""
+    ) -> Union[List[ChatCompletionRequest], ErrorResponse]:
+        """Preprocess contents request and convert it into appropriate chat requests"""
         # pylint: disable=redefined-outer-name
         # Fetch model name from super class: OpenAIServing
         model_name = self.models.base_model_paths[0].name
@@ -289,7 +289,7 @@ async def content_analysis(
         self,
         request: ContentsDetectionRequest,
         raw_request: Optional[Request] = None,
-    ):
+    ) -> Union[ContentsDetectionResponse, ErrorResponse]:
         """Function used to call chat detection and provide a /text/contents response"""
 
         # Apply task template if it exists

vllm_detector_adapter/generative_detectors/llama_guard.py

@@ -112,7 +112,7 @@ async def content_analysis(
         processed_result = []
         for result in results:
             # NOTE: we are only sending 1 of the error results
-            # and not every or not cumulative
+            # and not every one (not cumulative)
             if isinstance(result, ErrorResponse):
                 return result
             else:

vllm_detector_adapter/protocol.py

@@ -27,7 +27,7 @@ class ContentsDetectionRequest(BaseModel):
         ]
     )
     # Parameter passthrough
-    # NOTE: this server does support optional, `role_override`` parameter
+    # NOTE: this endpoint does support the optional `role_override` parameter
     # which allows use of different role when making a call to the guardrails LLM
     # via chat/completions
     detector_params: Optional[Dict] = {}