Fix broken conditionals (Ansible Core 2.19 / Ansible 12 compatibility)

- Added a new fact `__run_acmesh_is_installed` to indicate whether acme.sh is
  installed as boolean.

- Fixed broken conditionalnditionals. Ansible Core 2.19 / Ansible 12 introduced
  stricter behavior, e.g. non-boolean expressions in `when:` now raise errors
  by default. More information:
  https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_core_2.19.html#broken-conditionals

Closes #9.

Author: andreashaerter

changelogs/fragments/fix-broken-conditionals-core219.txt

@@ -0,0 +1,7 @@
+---
+
+minor_changes:
+  - Added a new fact ``__run_acmesh_is_installed`` to indicate whether acme.sh is installed as boolean.
+
+bugfixes:
+  - Fixed `broken conditionals <https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_core_2.19.html#broken-conditionals>`_. Ansible Core 2.19 / Ansible 12 introduced stricter behavior, e.g. non-boolean expressions in ``when:`` now raise errors by default.

roles/run/tasks/cert/default.yml

@@ -42,7 +42,7 @@
     decrypt: true
     force: false # do not overwrite anything if already existing on target
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
     - item['stat'] is defined
     - item['stat']['exists']
@@ -87,7 +87,7 @@
     decrypt: true
     force: false # do not overwrite anything if already existing on target
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
     - item['stat'] is defined
     - item['stat']['exists']
@@ -201,7 +201,7 @@
     chdir: "{{ run_acmesh_cfg_home }}"
   environment: "{{ run_acmesh_environment | default(omit) }}"
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
   changed_when:
     - __run_acmesh_issue_result['rc'] == 0
@@ -222,7 +222,7 @@
     group: "{{ run_acmesh_group }}"
     mode: "u=rwx,g=rx,o=" # 0750
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
   loop: "{{ run_acmesh_certs | selectattr('install', 'defined') | map(attribute='install') | selectattr('ca_file', 'defined') | list }}"
 
@@ -235,7 +235,7 @@
     group: "{{ run_acmesh_group }}"
     mode: "u=rwx,g=rx,o=" # 0750
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
   loop: "{{ run_acmesh_certs | selectattr('install', 'defined') | map(attribute='install') | selectattr('cert_file', 'defined') | list }}"
 
@@ -248,7 +248,7 @@
     group: "{{ run_acmesh_group }}"
     mode: "u=rwx,g=rx,o=" # 0750
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
   loop: "{{ run_acmesh_certs | selectattr('install', 'defined') | map(attribute='install') | selectattr('fullcain_file', 'defined') | list }}"
 
@@ -261,7 +261,7 @@
     group: "{{ run_acmesh_group }}"
     mode: "u=rwx,g=rx,o=" # 0750
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
   loop: "{{ run_acmesh_certs | selectattr('install', 'defined') | map(attribute='install') | selectattr('key_file', 'defined') | list }}"
 
@@ -309,7 +309,7 @@
     chdir: "{{ run_acmesh_cfg_home }}"
   environment: "{{ run_acmesh_environment | default(omit) }}"
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
   changed_when:
     - __run_acmesh_install_result['rc'] == 0
@@ -495,7 +495,7 @@
       exit 0
     executable: "/bin/bash" # Support for other shells untested (so far)
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
     - item is defined
     - item['domains'] is defined
@@ -516,7 +516,7 @@
     msg: "{{ item }}"
     verbosity: 3
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - run_acmesh_certs is defined
     - item | length > 0
   loop: >-
@@ -536,7 +536,7 @@
   args:
     chdir: "{{ run_acmesh_cfg_home }}"
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - ansible_verbosity > 3
   changed_when: false
   register: __run_acmesh_list_domains_result
@@ -547,6 +547,6 @@
     msg: "{{ __run_acmesh_list_domains_result['stdout_lines'] }}"
     verbosity: 3
   when:
-    - __run_acmesh_version_installed
-    - __run_acmesh_list_domains_result
+    - __run_acmesh_is_installed
+    - __run_acmesh_list_domains_result is defined
     - ansible_verbosity > 3

roles/run/tasks/init.yml

@@ -127,9 +127,10 @@
   changed_when: false
 
 
-- name: "Init | Set installed version as fact"
+- name: "Init | Set installed version as facts"
   ansible.builtin.set_fact:
-    __run_acmesh_version_installed: "{{ (__run_acmesh_version_installed_result) | ternary(__run_acmesh_version_installed_result['stdout'], false) }}"
+    __run_acmesh_is_installed: "{{ (__run_acmesh_version_installed_result is success) | ternary((__run_acmesh_version_installed_result['stdout'] | length > 0), false) }}"
+    __run_acmesh_version_installed: "{{ (__run_acmesh_version_installed_result is success) | ternary(__run_acmesh_version_installed_result['stdout'], false) }}"
 
 
 - name: "Init | Display installed version (if any, false means \"not installed\")"

roles/run/tasks/setup/install/default.yml

@@ -108,7 +108,7 @@
     suffix: "-acmesh"
   changed_when: false
   when:
-    - not __run_acmesh_version_installed
+    - not __run_acmesh_is_installed
   register: __run_acmesh_tempdir
 
 
@@ -117,7 +117,7 @@
     var: __run_acmesh_tempdir
     verbosity: 2
   when:
-    - not __run_acmesh_version_installed
+    - not __run_acmesh_is_installed
 
 
 - name: "Setup | Install | Default | git clone {{ __run_acmesh_git_url }}"
@@ -128,7 +128,7 @@
     dest: "{{ __run_acmesh_tempdir['path'] }}"
     update: true
   when:
-    - not __run_acmesh_version_installed
+    - not __run_acmesh_is_installed
 
 
 - name: "Setup | Install | Default | Ensure existence and permissions of main directories"
@@ -192,7 +192,7 @@
     chdir: "{{ __run_acmesh_tempdir['path'] }}"
     creates: "{{ run_acmesh_cfg_home }}/acme.sh"
   when:
-    - not __run_acmesh_version_installed
+    - not __run_acmesh_is_installed
   notify: "run_acmesh: set ownership and permissions"
 
 
@@ -233,8 +233,9 @@
   args:
     chdir: "{{ run_acmesh_cfg_home }}"
   when:
-    - __run_acmesh_version_installed
-    - __run_acmesh_version_upstream
+    - __run_acmesh_is_installed
+    - __run_acmesh_version_installed is defined
+    - __run_acmesh_version_upstream is defined
     - run_acmesh_autoupgrade is defined
     - run_acmesh_autoupgrade
     - __run_acmesh_version_installed is version(__run_acmesh_version_upstream, 'lt', version_type='semver')
@@ -279,9 +280,10 @@
   register: __run_acmesh_version_installed_result
 
 
-- name: "Setup | Install | Default | Update / overwrite installed version fact"
+- name: "Setup | Install | Default | Update / overwrite installed version facts"
   ansible.builtin.set_fact:
-    __run_acmesh_version_installed: "{{ __run_acmesh_version_installed_result | ternary(__run_acmesh_version_installed_result['stdout'], false) }}"
+    __run_acmesh_is_installed: "{{ (__run_acmesh_version_installed_result is success) | ternary((__run_acmesh_version_installed_result['stdout'] | length > 0), false) }}"
+    __run_acmesh_version_installed: "{{ (__run_acmesh_version_installed_result is success) | ternary(__run_acmesh_version_installed_result['stdout'], false) }}"
 
 
 - name: "Setup | Install | Default | Display installed version (if any, false means \"not installed\")"
@@ -333,7 +335,7 @@
     line: '\1grep -i "^\2'
     backrefs: true
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
     - __run_acmesh_version_installed is version('3.0.6', 'le', version_type='semver')
 
 

roles/run/tasks/setup/uninstall/default.yml

@@ -22,7 +22,7 @@
   args:
     removes: "{{ run_acmesh_cfg_home }}/acme.sh"
   when:
-    - __run_acmesh_version_installed
+    - __run_acmesh_is_installed
 
 
 - name: "Setup | Uninstall | Default | Remove packages"