Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent "Private Events" from being searched #6127

Merged
merged 1 commit into from
Dec 23, 2020
Merged

fix: Prevent "Private Events" from being searched #6127

merged 1 commit into from
Dec 23, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #6113

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Dec 23, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/1n2fflccp
✅ Preview: https://open-event-frontend-git-fork-sachinchauhan2889-private-events.eventyay.now.sh

@auto-label auto-label bot added the fix label Dec 23, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #6127 (6d3e308) into development (04ca9b1) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6127      +/-   ##
===============================================
- Coverage        23.45%   23.40%   -0.06%     
===============================================
  Files              517      517              
  Lines             5611     5611              
  Branches            69       69              
===============================================
- Hits              1316     1313       -3     
- Misses            4277     4280       +3     
  Partials            18       18
Impacted Files Coverage Δ
app/routes/explore.js 47.05% <ø> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ca9b1...6d3e308. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 1bd7ebd into fossasia:development Dec 23, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the private-events branch December 30, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search: Do not show "Private Events" in search results and do not list publicly on search engines
2 participants
@sachinchauhan2889 @iamareebjamal