Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivate features to simplify UI #490

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Deactivate features to simplify UI #490

merged 1 commit into from
Jan 1, 2025

Conversation

HungNgien
Copy link
Contributor

@HungNgien HungNgien commented Dec 30, 2024 •
edited by sourcery-ai bot
Loading

image
Temporarily hide items in sidebar: Event Metadata, Webhooks, Gift Cards and Bank Transfer

This PR resolves #468

Summary by Sourcery

Enhancements:

  • Disable bank transfer import and refund export functionality.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Dec 30, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This PR temporarily disables several features in the user interface to simplify the user experience. It deactivates the bank transfer import and refund export functionality and removes the "Event Metadata", "Webhooks", "Gift Cards", and "Bank Transfer" items from the sidebar navigation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Disabled bank transfer import and refund export functionality
  • Commented out the code that adds the bank transfer import and refund export options to the organizer navigation.
  • Added a comment explaining that the functionality is temporarily disabled.
 src/pretix/plugins/banktransfer/signals.py
Removed sidebar navigation items
  • Commented out the code that adds the "Event Metadata", "Webhooks", and "Gift Cards" items to the sidebar navigation.
  • Commented out the code that adds the "Bank Transfer" item to the sidebar navigation.
 src/pretix/control/navigation.py

Assessment against linked issues

Issue Objective Addressed Explanation
#468 Hide 'Event metadata' and 'Webhooks' under the settings tab in Organizer Account view ✅
#468 Hide gift cards in Organizer Account view ✅
#468 Hide bank transfer options in Organizer Account view ✅
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@HungNgien HungNgien marked this pull request as ready for review December 30, 2024 15:06
sourcery-ai[bot]
sourcery-ai bot reviewed Dec 30, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @HungNgien - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Instead of commenting out code, consider removing it entirely (git history can be used to restore if needed) or implementing proper feature flags for temporary feature toggles. Commented-out code tends to become stale and creates maintenance overhead.
  • Please expand the PR description to explain the rationale behind disabling these specific features and provide an estimated timeline for when they might be re-enabled. This context is important for future maintenance.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mariobehling mariobehling requested a review from hongquan January 1, 2025 17:23
@mariobehling mariobehling merged commit f3642d3 into fossasia:development Jan 1, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@mariobehling mariobehling mariobehling approved these changes

@hongquan hongquan Awaiting requested review from hongquan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deactivate features to simplify UI
2 participants
@HungNgien @mariobehling