Add a could-not-parse-json command error instead of raising

Author: azimux

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.7] - 2025-05-30
+
+- Add a could-not-parse-json command error instead of raising
+
 ## [0.0.6] - 2025-05-21
 
 - Give an error if no ai api services have been provided

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    foobara-llm-backed-command (0.0.6)
+    foobara-llm-backed-command (0.0.7)
       foobara (~> 0.0.92)
       foobara-ai (~> 0.0.1)
       foobara-json-schema-generator (~> 0.0.1)
@@ -12,7 +12,7 @@ GEM
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
     ast (2.4.3)
-    base64 (0.2.0)
+    base64 (0.3.0)
     bigdecimal (3.2.0)
     byebug (12.0.0)
     coderay (1.1.3)
@@ -58,7 +58,7 @@ GEM
       foobara-type-generator (~> 0.0.1)
       foobara-typescript-react-command-form-generator (~> 0.0.1)
       foobara-typescript-remote-command-generator (~> 0.0.1)
-    foobara (0.0.127)
+    foobara (0.0.129)
       bigdecimal
       foobara-lru-cache (~> 0.0.2)
       foobara-util (~> 0.0.11)
@@ -196,7 +196,7 @@ GEM
     public_suffix (6.0.2)
     racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.2.1)
+    rake (13.3.0)
     rb-fsevent (0.11.2)
     rb-inotify (0.11.1)
       ffi (~> 1.0)

src/llm_backed_execute_method.rb

@@ -11,6 +11,12 @@ module LlmBackedExecuteMethod
 
     on_include do
       depends_on Ai::AnswerBot::Ask
+      possible_error :could_not_parse_result_json,
+                     message: "Could not parse answer",
+                     context: {
+                       raw_answer: :string,
+                       stripped_answer: :string
+                     }
     end
 
     def execute
@@ -77,24 +83,32 @@ def llm_instructions
     def parse_answer
       stripped_answer = answer.gsub(/<THINK>.*?<\/THINK>/mi, "")
       fencepostless_answer = stripped_answer.gsub(/^\s*```\w*\n(.*)```\s*\z/m, "\\1")
+
       # TODO: should we verify against json-schema or no?
       self.parsed_answer = begin
         JSON.parse(fencepostless_answer)
-      rescue => e
+      rescue JSON::ParserError
         # see if we can extract the last fence-posts content just in case
         last_fence_post_regex = /```\w*\s*\n((?:(?!```).)+)\n```(?:(?!```).)*\z/m
+
         begin
           match = last_fence_post_regex.match(stripped_answer)
+
           if match
-            JSON.parse(match[1])
+            fencepostless_answer = match[1]
+            JSON.parse(fencepostless_answer)
           else
             # :nocov:
-            raise e
+            raise
             # :nocov:
           end
-        rescue
+        rescue JSON::ParserError => e
+          # TODO: figure out how to test this code path
           # :nocov:
-          raise e
+          add_runtime_error :could_not_parse_result_json,
+                            "Could not parse result JSON: #{e.message}",
+                            raw_answer: answer,
+                            stripped_answer: fencepostless_answer
           # :nocov:
         end
       end

version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module LlmBackedCommandVersion
-    VERSION = "0.0.6".freeze
+    VERSION = "0.0.7".freeze
 
     local_ruby_version = File.read("#{__dir__}/.ruby-version").chomp
     local_ruby_version_minor = local_ruby_version[/\A(\d+\.\d+)\.\d+\z/, 1]