Add DeleteApiKey command

Author: azimux

Gemfile.lock

@@ -16,7 +16,7 @@ GEM
       ffi-compiler (~> 1.0)
     ast (2.4.3)
     base64 (0.3.0)
-    bigdecimal (3.2.2)
+    bigdecimal (3.2.3)
     byebug (12.0.0)
     coderay (1.1.3)
     crack (1.0.0)
@@ -64,14 +64,14 @@ GEM
       foobara-type-generator (< 2.0.0)
       foobara-typescript-react-command-form-generator (< 2.0.0)
       foobara-typescript-remote-command-generator (< 2.0.0)
-    foobara (0.1.1)
+    foobara (0.1.14)
       bigdecimal
       foobara-lru-cache (< 2.0.0)
       foobara-util (< 2.0.0)
       inheritable-thread-vars (< 2.0.0)
-    foobara-command-generator (0.0.3)
-      foobara
-      foobara-files-generator
+    foobara-command-generator (0.1.0)
+      foobara (>= 0.1.7, < 2.0.0)
+      foobara-files-generator (< 2.0.0)
     foobara-domain-generator (0.0.3)
       foobara
       foobara-files-generator
@@ -80,7 +80,7 @@ GEM
       foobara-files-generator
     foobara-dotenv-loader (0.0.3)
       dotenv
-    foobara-empty-ruby-project-generator (1.0.1)
+    foobara-empty-ruby-project-generator (1.0.4)
       extract-repo (< 2.0.0)
       foobara (>= 0.1.1, < 2.0.0)
       foobara-files-generator (< 2.0.0)
@@ -113,7 +113,7 @@ GEM
     foobara-resque-scheduler-connector-generator (0.0.2)
       foobara
       foobara-files-generator
-    foobara-rubocop-rules (1.0.1)
+    foobara-rubocop-rules (1.0.3)
       rubocop
       rubocop-rspec
     foobara-sh-cli-connector (1.1.0)
@@ -129,11 +129,11 @@ GEM
     foobara-typescript-react-command-form-generator (1.1.0)
       foobara (>= 0.1.1, < 2.0.0)
       foobara-typescript-remote-command-generator (< 2.0.0)
-    foobara-typescript-remote-command-generator (1.1.0)
-      foobara (>= 0.1.1, < 2.0.0)
+    foobara-typescript-remote-command-generator (1.1.2)
+      foobara (>= 0.1.14, < 2.0.0)
       foobara-files-generator (< 2.0.0)
-    foobara-util (1.0.2)
-    formatador (1.2.0)
+    foobara-util (1.0.3)
+    formatador (1.2.1)
       reline
     guard (2.19.1)
       formatador (>= 0.2.4)
@@ -151,14 +151,14 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    hashdiff (1.2.0)
+    hashdiff (1.2.1)
     inheritable-thread-vars (0.0.3)
     io-console (0.8.1)
     irb (1.15.2)
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.13.2)
+    json (2.15.0)
     jwt (3.1.2)
       base64
     language_server-protocol (3.17.0.5)
@@ -167,7 +167,7 @@ GEM
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     logger (1.7.0)
-    lumberjack (1.4.0)
+    lumberjack (1.4.2)
     method_source (1.1.0)
     nenv (0.3.0)
     notiffany (0.1.3)
@@ -181,7 +181,7 @@ GEM
     pp (0.6.2)
       prettyprint
     prettyprint (0.2.0)
-    prism (1.4.0)
+    prism (1.5.1)
     pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -201,10 +201,10 @@ GEM
     rdoc (6.14.2)
       erb
       psych (>= 4.0.0)
-    regexp_parser (2.11.2)
+    regexp_parser (2.11.3)
     reline (0.6.2)
       io-console (~> 0.5)
-    rexml (3.4.1)
+    rexml (3.4.4)
     rspec (3.13.1)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -220,25 +220,25 @@ GEM
     rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.5)
-    rubocop (1.80.0)
+    rspec-support (3.13.6)
+    rubocop (1.81.1)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.46.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.46.0)
+    rubocop-ast (1.47.1)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
-    rubocop-rspec (3.6.0)
+    rubocop-rspec (3.7.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     ruby-prof (1.7.2)
@@ -254,9 +254,9 @@ GEM
     stringio (3.1.7)
     thor (1.4.0)
     timecop (0.9.10)
-    unicode-display_width (3.1.5)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
     vcr (6.3.1)
       base64
     webmock (3.25.1)

spec/delete_api_key_spec.rb

@@ -0,0 +1,51 @@
+RSpec.describe Foobara::Auth::DeleteApiKey do
+  after { Foobara.reset_alls }
+
+  before do
+    Foobara::Persistence.default_crud_driver = Foobara::Persistence::CrudDrivers::InMemory.new
+  end
+
+  let(:command) { described_class.new(inputs) }
+  let(:outcome) { command.run }
+  let(:result) { outcome.result }
+  let(:errors) { outcome.errors }
+  let(:errors_hash) { outcome.errors_hash }
+
+  let(:inputs) do
+    { token: token_id_to_delete }
+  end
+
+  let(:user) { Foobara::Auth::CreateUser.run!(username: "Basil", email: "[email protected]") }
+
+  context "when there are api keys" do
+    let(:api_keys) do
+      (0..4).map do
+        Foobara::Auth::CreateApiKey.run!(user:)
+      end
+    end
+    let(:api_key_summaries) do
+      Foobara::Auth::GetApiKeySummaries.run!(user:)
+    end
+    let(:token_id_to_delete) { api_key_summaries[2].token_id }
+
+    def token_count
+      Foobara::Auth::Types::Token.transaction do
+        Foobara::Auth::Types::Token.count
+      end
+    end
+
+    it "deletes the api key from the user" do
+      api_keys
+
+      expect(Foobara::Auth::GetApiKeySummaries.run!(user:).size).to be(5)
+      expect(Foobara::Auth::FindUser.run!(id: user.id).api_keys.map(&:id)).to include(token_id_to_delete)
+
+      expect {
+        expect(outcome).to be_success
+      }.to change { token_count }.by(-1)
+
+      expect(Foobara::Auth::FindUser.run!(id: user.id).api_keys.map(&:id)).to_not include(token_id_to_delete)
+      expect(Foobara::Auth::GetApiKeySummaries.run!(user:).size).to be(4)
+    end
+  end
+end

src/delete_api_key.rb

@@ -0,0 +1,46 @@
+require "securerandom"
+require "base64"
+
+require_relative "build_secret"
+require_relative "create_token"
+
+module Foobara
+  module Auth
+    class DeleteApiKey < Foobara::Command
+      inputs do
+        token Types::Token, :required
+      end
+
+      def execute
+        remove_api_key_from_user
+        delete_token
+
+        nil
+      end
+
+      def load_records
+        super
+        self.user = Types::User.that_owns(token, :api_keys)
+      end
+
+      attr_accessor :user
+
+      # should Foobara do this automatically? Or at least support it? Similar to CASCADE in SQL
+      def remove_api_key_from_user
+        api_keys = user.api_keys
+
+        if api_keys.include?(token)
+          user.api_keys = api_keys - [token]
+        else
+          # :nocov:
+          raise "User has no such api key"
+          # :nocov:
+        end
+      end
+
+      def delete_token
+        token.hard_delete!
+      end
+    end
+  end
+end