Fix domain map temperature to 1 for o1 models

Author: azimux

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.14] - 2025-07-05
+
+- o1 models don't support temperature so force it to 1
+
 ## [0.0.13] - 2025-06-27
 
 - Add GenerateChatCompletion command

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    foobara-ai (0.0.13)
+    foobara-ai (0.0.14)
 
 GEM
   remote: https://rubygems.org/
@@ -55,7 +55,7 @@ GEM
       foobara-type-generator (~> 0.0.1)
       foobara-typescript-react-command-form-generator (~> 0.0.1)
       foobara-typescript-remote-command-generator (~> 0.0.1)
-    foobara (0.0.134)
+    foobara (0.0.135)
       bigdecimal
       foobara-lru-cache (~> 0.0.2)
       foobara-util (>= 1.0.0)
@@ -194,7 +194,7 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.11.1)
       ffi (~> 1.0)
-    rdoc (6.14.1)
+    rdoc (6.14.2)
       erb
       psych (>= 4.0.0)
     regexp_parser (2.10.0)

spec/foobara/answer_bot/generate_next_message_spec.rb

@@ -50,7 +50,7 @@
   context "when using anthropic" do
     let(:model) { "claude-3-5-sonnet-20241022" }
 
-    it "is successful", vcr: { record: :once } do
+    it "is successful", vcr: { record: :none } do
       expect(outcome).to be_success
       expect(result.content).to match(/vinegar/i)
     end

src/foobara/ai/answer_bot/domain_mappers/open_ai_api/chat_to_generate_chat_completion.rb

@@ -21,7 +21,9 @@ def map
               }
 
               if temperature
-                inputs[:temperature] = temperature
+                # NOTE: some models don't support temperature, like o1. Instead of possibly receiving an error
+                # we will set the temperature to 1 which prevents a 400. Maybe print a warning instead?
+                inputs[:temperature] = model_supports_temperature? ? temperature : 1
               end
 
               if model
@@ -42,6 +44,10 @@ def temperature
             def model
               from[:model]
             end
+
+            def model_supports_temperature?
+              model && model.to_s !~ /\Ao1(-|$)/
+            end
           end
         end
       end

version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Ai
-    VERSION = "0.0.13".freeze
+    VERSION = "0.0.14".freeze
     MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
   end
 end