Restore IE11 compatibility #4
Conversation
- Add IE 11 to .babelrc compatibility list - Include core-js polyfills - Include regenerator-runtime polyfill
|
Nice one! |
|
When will this fix be released? |
|
@devongovett Please get this shipped, this currently crashes all apps that include |
|
Hi folks! Thanks for your enthusiasm about this PR. Instead of commenting on this thread, please consider:
My inbox thanks you! 😄 As a reminder, if you're experiencing this issue in a package that requires dfa, you can work around the problem by using npm-force-resolutions to keep dfa at 1.1.0. |
|
@rdebeasi |
|
Hello @satheeshnatarajan! I am not a maintainer of dfa and I don't have control over when this PR is merged. Thanks! 😄 |
|
@devongovett - Any plan to merge this PR? |
|
Hello, please could you merge that PR ! It brokes my app solution in IE11, very annoying. |
|
Guys, I'm trying to get in touch with @devongovett but he still doesn't answer on twitter... |
|
@devongovett et @blikblum please, could you do something for that PR ? It would be very kind and helpful. Thanks. |
|
@devongovett et @blikblum : Hello, i'm back (again) to ask you if you could please be very kind and merge that PR to the code ? I really need to get the compatibility back to IE11 for the company i'm working for as front-end developer. Thanks a lot. |
|
Hi @syriaca! As a reminder, you can work around the problem by using npm-force-resolutions to keep dfa at 1.1.0. This will resolve the IE11 issue even without this PR being merged. I've been using this solution in production for a little over a year now. I'd like this PR to be merged too, but adding comments won't speed up the process. Instead of commenting on this thread, please consider adding a reaction emoji to the issue or PR. Thank you! |
|
Add this to your |
|
At this point, I don't think supporting IE 11 is worth it since it has been killed by Microsoft themselves. Also it adds to the bundle size unnecessarily for most people. If you really still need to, you can always run Babel over your node_modules yourself if you want. |
This PR restores IE11 compatibility by adding that browser to Babel presets and including core-js and regenerator-runtime. This configuration provides roughly the build setup that we had prior to eed4375, but it runs on the latest version of Babel and avoids deprecated options. (I've also added Safari 10 to the compatibility list for the sake of completeness.)
This PR resolves #2. I've tested locally with an affected project and
npm link, and this change does solve the problem for me.I've also replaced the deprecated
prepublishscript withprepare. This change should make it easier to test this change by installing from a fork on GitHub.Thank you in advance for taking a look at this PR! 😄