Wikilink markdown link generation deletes/recreates each time the file is saved

[sdeiley]

Describe the bug

Succinct Description:

When I save a file, with or without changes, Foam either removes existing markdown links for that notes wikilinks, or it generates them if they aren't there.

Exact Observed Behavior

Consider a simple markdown file with the following:

## Title
[[root.AnotherNote.md]]

Now I save the file. I see

## Title
[[root.AnotherNote.md]]


[//begin]: # "Autogenerated link references for markdown compatibility"
[root.AnotherNote.md] root.AnotherNote "Another Note"
[//end]: # "Autogenerated link references"

However, if I save again, I see (notice additional newlines at bottom):

## Title
[[root.AnotherNote.md]]

Additional Notes

• there is a clickable message saying "Wikilink definitions (out of date)" which, when clicked, deletes the markdown links.
• Foam: Run Janitor (experimental) also does the exact thing (add or remove markdown links) to all files in the directory.

Settings

My only explicit foam setting is:

{
...
  "foam.edit.linkReferenceDefinitions": "withoutExtensions",
}

Small Reproducible Example

No response

Steps to Reproduce the Bug or Issue

1. Fresh install of foam version 0.25.8 (note: I have other markdown extensions, I am not sure if they are the problem).
2. Change foam setting "foam.edit.linkReferenceDefinitions": "withoutExtensions"
3. Create two notes. Wikilink one from the other.
4. CNTL+SHIFT+P File: Save
5. Observe changes to file
6. Repeate Steps 4/5

Expected behavior

I didn't expect the links to be deleted by saving or Foam: Run Janitor. I also don't expect the little description "Wikilinks out of date" to be there.

Screenshots or Videos

Operating System Version

macOS

Visual Studio Code Version

Version: 1.86.1 (Universal) Commit: 31c37ee8f63491495ac49e43b8544550

Additional context

No response

[riccardoferretti]

I cannot reproduce this from the given steps, can you please provide a repo to use as base where the issue can be reproduced?

[hellos3b]

@riccardoferretti I am running into the same issue, I think it has to do with periods in the filename.

I have a file named 1.2.3 Filename.md, and each time I hit save it toggles -- Also notice that the color of the link changes from unknown to known each save:

In the auto complete, I see two entries, one without filename -- possibly related?

Issue is not seen on links without periods

---

Mac OS as well.

[hellos3b]

Managed to create a test case that replicates the issue I'm seeing, in uri.test.ts

  it('supports periods in filename', () => {
    expect(URI.file('/my/file.md').resolve('1.2.3 Hello World')).toEqual(
      URI.file('/my/1.2.3 Hello World.md')
    );
  });

[hellos3b]

The problem is because in changeExtension() it looks like it assumes that this link's file extension is ".3 Hello World" instead of ""

foam/packages/foam-vscode/src/core/utils/path.ts

Lines 112 to 123 in 61961f0

	export function changeExtension(
	path: string,
	from: string,
	to: string
	): string {
	const old = getExtension(path);
	if ((from === '*' && old !== to) || old === from) {
	path = path.substring(0, path.length - old.length);
	return to ? path + to : path;
	}
	return path;
	}

[riccardoferretti]

This issue should resolve soon as I have made a few changes in the way we (re-)compute wikilink definitions, related to #1116 and #1503

I haven't pushed those yet as they will create conflicts with #1482