Skip to content

Commit e0f3c36

Browse files
committed
Clarify ARCHIVED filtering is caller-side, not default
Remove "hidden from list queries by default" language from proto comments and CLI help. Archived launch plans are not automatically excluded from list results — callers must add a ne(state,2) filter. Signed-off-by: Blake Naccarato <blake.naccarato@gmail.com> Signed-off-by: Blake <blaketastic2@gmail.com>
1 parent 8705f09 commit e0f3c36

File tree

7 files changed

+13
-13
lines changed

7 files changed

+13
-13
lines changed

flytectl/cmd/update/launch_plan.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ Deactivates a ` + "`launch plan <https://docs.flyte.org/en/latest/user_guide/pro
2828
2929
flytectl update launchplan -p flytesnacks -d development core.control_flow.merge_sort.merge_sort --version v1 --deactivate
3030
31-
Archives a launch plan version, marking it as old/unused. Archived launch plans are hidden from list
32-
queries by default and any active schedule is disabled. Archived launch plans can still be used to
33-
launch executions:
31+
Archives a launch plan version, marking it as old/unused. Archived launch plans can be filtered out
32+
of list queries using ne(state,2) and any active schedule is disabled. Archived launch plans can
33+
still be used to launch executions:
3434
::
3535
3636
flytectl update launchplan -p flytesnacks -d development core.control_flow.merge_sort.merge_sort --version v1 --archive

flyteidl/clients/go/assets/admin.swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flyteidl/gen/pb-es/flyteidl/admin/launch_plan_pb.ts

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flyteidl/gen/pb-go/flyteidl/admin/launch_plan.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flyteidl/gen/pb-go/gateway/flyteidl/service/admin.swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flyteidl/gen/pb_rust/flyteidl.admin.rs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flyteidl/protos/flyteidl/admin/launch_plan.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ message LaunchPlanCreateResponse {
4040
enum LaunchPlanState {
4141
INACTIVE = 0;
4242
ACTIVE = 1;
43-
// Archived launch plans are considered old/unused and can be filtered out of list queries.
44-
// Archiving a launch plan also disables any active schedule.
43+
// Archived launch plans are considered old/unused and can be excluded from list queries
44+
// using a ne(state,2) filter. Archiving a launch plan also disables any active schedule.
4545
// An archived launch plan can still be used to launch executions.
4646
ARCHIVED = 2;
4747
}

0 commit comments

Comments
 (0)