[packages] make-deps-path-based
should include everything in a federated plugin
#168538
Labels
c: contributor-productivity
Team-specific productivity, code health, technical debt.
P2
Important issues not at the top of the work list
package
flutter/packages repository. See also p: labels.
team-ecosystem
Owned by Ecosystem team
triaged-ecosystem
Triaged by Ecosystem team
Uh oh!
There was an error while loading. Please reload this page.
Currently the tool logic for
make-deps-path-based
has logic that was intended to solve the issue of transitive dependencies by havingfoo/example
get all the same overrides asfoo
. That's usually enough, but not always; in particular, cases where some unrelated plugin's example depends onfoo
, but the plugin itself doesn't, then the example gets onlyfoo
overridden but none offoo
's sub-dependencies, which causes CI failures. See flutter/packages#9212 for an example.The tool should have additional logic that anything depending on
foo*
gets all overrides in thefoo*
conceptual plugin group, to avoid missed cases.(In general the changes to other packages aren't actually necessary at the stage where this causes problems, but having the tool generate partial changes that don't work just causes confusion.)
The text was updated successfully, but these errors were encountered: