Skip to content

[packages] make-deps-path-based should include everything in a federated plugin #168538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stuartmorgan-g opened this issue May 8, 2025 · 1 comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented May 8, 2025

Currently the tool logic for make-deps-path-based has logic that was intended to solve the issue of transitive dependencies by having foo/example get all the same overrides as foo. That's usually enough, but not always; in particular, cases where some unrelated plugin's example depends on foo, but the plugin itself doesn't, then the example gets only foo overridden but none of foo's sub-dependencies, which causes CI failures. See flutter/packages#9212 for an example.

The tool should have additional logic that anything depending on foo* gets all overrides in the foo* conceptual plugin group, to avoid missed cases.

(In general the changes to other packages aren't actually necessary at the stage where this causes problems, but having the tool generate partial changes that don't work just causes confusion.)

@stuartmorgan-g stuartmorgan-g added c: contributor-productivity Team-specific productivity, code health, technical debt. package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team P2 Important issues not at the top of the work list triaged-ecosystem Triaged by Ecosystem team labels May 8, 2025
@Gustl22
Copy link
Contributor

Gustl22 commented May 16, 2025

Maybe another reason to use Workspaces, although the implications were already discussed. Just wanted to mention this here as reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Development

No branches or pull requests

2 participants