Auto merge of rust-lang#77524 - Patryk27:fixes/66228, r=estebank

bors · bors · commit dcd8c8e739f4 · 2021-01-13T20:35:58.000Z
Rework diagnostics for wrong number of generic args (fixes rust-lang#66228 and rust-lang#71924) This PR reworks the `wrong number of {} arguments` message, so that it provides more details and contextual hints.
diff --git a/clippy_lints/src/utils/hir_utils.rs b/clippy_lints/src/utils/hir_utils.rs
@@ -744,7 +744,7 @@ impl<'a, 'tcx> SpanlessHash<'a, 'tcx> {
                     }
                     for segment in path.segments {
                         segment.ident.name.hash(&mut self.s);
-                        self.hash_generic_args(segment.generic_args().args);
+                        self.hash_generic_args(segment.args().args);
                     }
                 },
                 QPath::TypeRelative(ref ty, ref segment) => {

Original file line number	Diff line number	Diff line change
`@@ -744,7 +744,7 @@ impl<'a, 'tcx> SpanlessHash<'a, 'tcx> {`
`744`	`744`	`}`
`745`	`745`	`for segment in path.segments {`
`746`	`746`	`segment.ident.name.hash(&mut self.s);`
`747`		`- self.hash_generic_args(segment.generic_args().args);`
	`747`	`+ self.hash_generic_args(segment.args().args);`
`748`	`748`	`}`
`749`	`749`	`},`
`750`	`750`	`QPath::TypeRelative(ref ty, ref segment) => {`