Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software title "Save changes?" modal is shown when only Self Service option is changed #25067

Open
jmwatts opened this issue Dec 31, 2024 · 0 comments
Assignees
Labels
bug Something isn't working as documented #g-mdm MDM product group :incoming New issue in triage process. :product Product Design department (shows up on 🦢 Drafting board) :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Milestone

Comments

@jmwatts
Copy link
Member

jmwatts commented Dec 31, 2024

Fleet version: 4.62.0

Web browser and operating system: Chrome 131.0.6778.205 on macOS


💥  Actual behavior

Screenshot 2024-12-31 at 12 07 50 PM
Modal is shown even for a software title set to manual install and only Self Service install method changes

🧑‍💻  Steps to reproduce

  1. Software >> Add software
  2. Choose either Fleet maintained or custom package
  3. Choose "Manual" Install and "All hosts" Target. Select "Self-service" checkbox
  4. Click Add software
  5. Find and click on the newly created software title
  6. Click Actions >> Edit
  7. Uncheck the Self-service checkbox and click Save

🕯️ Expected results

Per the design document, "Show this modal if any fields change (including target) except self-service"
Screenshot 2024-12-31 at 12 05 38 PM

@jmwatts jmwatts added bug Something isn't working as documented #g-mdm MDM product group :product Product Design department (shows up on 🦢 Drafting board) ~unreleased bug This bug was found in an unreleased version of Fleet. :incoming New issue in triage process. labels Dec 31, 2024
@jmwatts jmwatts added this to the 4.62.0-tentative milestone Dec 31, 2024
@jmwatts jmwatts added the :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. label Jan 2, 2025
@ghernandez345 ghernandez345 self-assigned this Jan 2, 2025
ghernandez345 added a commit that referenced this issue Jan 3, 2025
relates to #25067, #25061

includes two fixes for the scoped software via labels feature:

1. update the delete label modal copy
2. don't show the confirm changes modal if only the self service value
has changed.

- [x] Manual QA for all new/changed functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented #g-mdm MDM product group :incoming New issue in triage process. :product Product Design department (shows up on 🦢 Drafting board) :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Development

No branches or pull requests

2 participants