2.4.1 fails to build: `finufft_core.h: error: field 'mstu' has incomplete type 'std::array<long long int, 3>'`

[barracuda156]

--->  Building finufft
Executing:  cd "/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/finufft-2.4.1" && /usr/bin/make -j6 -w fortran lib CC="/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cc/opt/local/bin/gcc-mp-14" CXX="/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14" OBJC="/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/objc/opt/local/bin/gcc-mp-14" OBJCXX="/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/objcxx/opt/local/bin/g++-mp-14" FC="/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14" F77="/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/f77/opt/local/bin/gfortran-mp-14" F90="/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/f90/opt/local/bin/gfortran-mp-14" PYTHON="/opt/local/bin/python3.11" INSTALL="/usr/bin/install -c" 
make: Entering directory `/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/finufft-2.4.1'
mkdir -p deps
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -m32 -Iinclude -Ideps/xsimd/include -I/opt/local/include -fPIC -fopenmp fortran/directft/dirft1d.f -o fortran/directft/dirft1d.o
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -m32 -Iinclude -Ideps/xsimd/include -I/opt/local/include -fPIC -fopenmp fortran/directft/dirft2d.f -o fortran/directft/dirft2d.o
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -m32 -Iinclude -Ideps/xsimd/include -I/opt/local/include -fPIC -fopenmp fortran/directft/dirft3d.f -o fortran/directft/dirft3d.o
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -m32 -Iinclude -Ideps/xsimd/include -I/opt/local/include -fPIC -fopenmp fortran/directft/dirft1df.f -o fortran/directft/dirft1df.o
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -m32 -Iinclude -Ideps/xsimd/include -I/opt/local/include -fPIC -fopenmp fortran/directft/dirft2df.f -o fortran/directft/dirft2df.o
Checking XSIMD external dependency...
Cloning repository https://github.com/xtensor-stack/xsimd.git at tag 13.0.0 into directory deps/xsimd
f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs]
Cloning into 'deps/xsimd'...
f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs]
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -m32 -Iinclude -Ideps/xsimd/include -I/opt/local/include -fPIC -fopenmp fortran/directft/dirft3df.f -o fortran/directft/dirft3df.o
f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs]
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -m32 -Iinclude -Ideps/xsimd/include -I/opt/local/include -fPIC -fopenmp fortran/directft/prini.f -o fortran/directft/prini.o
f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs]
2025-07-09 20:25:36.385 git-remote-https[76647:903] CFPreferences: user home directory at file://localhost/opt/local/var/macports/home/ is unavailable. User domains will be volatile.
warning: refs/tags/13.0.0 af95fe26b4abc430c8c143c49dbba1c009addbd1 is not a commit!
Note: switching to '5ac7edf30d0f519e0b7344b933382e4fc02fdee7'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

xsimd installed in deps/xsimd
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/finufft_utils.cpp -o src/finufft_utils.o
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/spreadinterp.cpp -o src/spreadinterp.o
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/fft.cpp -o src/fft.o
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/finufft_core.cpp -o src/finufft_core.o
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/c_interface.cpp -o src/c_interface.o
/opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp fortran/finufftfort.cpp -o fortran/finufftfort.o
In file included from include/finufft/fft.h:167,
                 from src/fft.cpp:2:
include/finufft/finufft_core.h:162:25: error: field 'mstu' has incomplete type 'std::array<long long int, 3>'
  162 |   std::array<BIGINT, 3> mstu; // number of modes in x,y,z directions
      |                         ^~~~
compilation terminated due to -Wfatal-errors.
make: *** [src/fft.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from include/finufft/fft.h:167,
                 from src/finufft_core.cpp:1:
include/finufft/finufft_core.h:162:25: error: field 'mstu' has incomplete type 'std::array<long long int, 3>'
  162 |   std::array<BIGINT, 3> mstu; // number of modes in x,y,z directions
      |                         ^~~~
compilation terminated due to -Wfatal-errors.
make: *** [src/finufft_core.o] Error 1
In file included from include/finufft/finufft_utils.hpp:11,
                 from src/spreadinterp.cpp:3:
include/finufft/finufft_core.h:162:25: error: field 'mstu' has incomplete type 'std::array<long long int, 3>'
  162 |   std::array<BIGINT, 3> mstu; // number of modes in x,y,z directions
      |                         ^~~~
compilation terminated due to -Wfatal-errors.
make: *** [src/spreadinterp.o] Error 1
In file included from fortran/finufftfort.cpp:22:
include/finufft/finufft_core.h:162:25: error: field 'mstu' has incomplete type 'std::array<long long int, 3>'
  162 |   std::array<BIGINT, 3> mstu; // number of modes in x,y,z directions
      |                         ^~~~
compilation terminated due to -Wfatal-errors.
make: *** [fortran/finufftfort.o] Error 1
In file included from include/finufft/finufft_utils.hpp:11,
                 from src/finufft_utils.cpp:6:
include/finufft/finufft_core.h:162:25: error: field 'mstu' has incomplete type 'std::array<long long int, 3>'
  162 |   std::array<BIGINT, 3> mstu; // number of modes in x,y,z directions
      |                         ^~~~
compilation terminated due to -Wfatal-errors.
make: *** [src/finufft_utils.o] Error 1

[mreineck]

Very interesting. That could happen because we forgot to add an include <array>' at the top of finufft_core.h`, but it's strange that other compilers don't complain.

If you tried this installation from a local clone of the repo, could you please check whether the compilation works if you add this include statement?

[barracuda156]

That indeed fixes array error, but then the build fails on this: ``` Checking XSIMD external dependency... Cloning repository https://github.com/xtensor-stack/xsimd.git at tag 13.0.0 into directory deps/xsimd Cloning into 'deps/xsimd'... 2025-07-10 15:35:34.389 git-remote-https[85331:903] CFPreferences: user home directory at file://localhost/opt/local/var/macports/home/ is unavailable. User domains will be volatile. f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs] f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs] f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs] f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs] f951: Warning: Nonexistent include directory 'deps/xsimd/include' [-Wmissing-include-dirs] warning: refs/tags/13.0.0 af95fe26b4abc430c8c143c49dbba1c009addbd1 is not a commit! Note: switching to '5ac7edf30d0f519e0b7344b933382e4fc02fdee7'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c <new-branch-name> Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false xsimd installed in deps/xsimd /opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -m32 -Iinclude -Ideps/xsimd/include -I/opt/local/include -fPIC -fopenmp fortran/directft/dirft3df.f -o fortran/directft/dirft3df.o /opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/fc/opt/local/bin/gfortran-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -m32 -Iinclude -Ideps/xsimd/include -I/opt/local/include -fPIC -fopenmp fortran/directft/prini.f -o fortran/directft/prini.o /opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/finufft_utils.cpp -o src/finufft_utils.o /opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/spreadinterp.cpp -o src/spreadinterp.o /opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/fft.cpp -o src/fft.o /opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/finufft_core.cpp -o src/finufft_core.o /opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp src/c_interface.cpp -o src/c_interface.o /opt/local/var/macports/build/_opt_local_ppcports_math_finufft/finufft/work/compwrap/cxx/opt/local/bin/g++-mp-14 -c -O3 -funroll-loops -fcx-limited-range -ffp-contract=fast -fno-math-errno -fno-signed-zeros -fno-trapping-math -fassociative-math -freciprocal-math -fmerge-all-constants -ftree-vectorize -Os -arch ppc -Wfatal-errors -Os -arch ppc -D_GLIBCXX_USE_CXX11_ABI=0 -Iinclude -Ideps/xsimd/include -fPIC -std=c++17 -fopenmp fortran/finufftfort.cpp -o fortran/finufftfort.o src/spreadinterp.cpp: In function 'constexpr auto finufft::spreadinterp::{anonymous}::BestSIMDHelper()': src/spreadinterp.cpp:59:19: error: 'make_sized_batch' is not a member of 'xsimd' 59 | return xsimd::make_sized_batch<T, K>{}; | ^~~~~~~~~~~~~~~~ compilation terminated due to -Wfatal-errors. make: *** [src/spreadinterp.o] Error 1 make: *** Waiting for unfinished jobs.... ```

[barracuda156]

P. S. xsimd as such worked on powerpc (there are no SIMD for it in xsimd, but w/e generic code is there did not break anything at least), as of xtensor-stack/xsimd#993

[barracuda156]

@mreineck This is likely a bug here: https://github.com/flatironinstitute/finufft/blob/2c677b2247dbea0763e3796cc009c7ba9dfdb6af/src/spreadinterp.cpp#L98C36-L98C52

This assumes that make_sized_batch is available, but that is not guaranteed. It is declared here: https://github.com/xtensor-stack/xsimd/blob/5bb532075af7ee0f8a85f156215703fd652ba50b/include/xsimd/types/xsimd_batch.hpp#L1508-L1516

But the header is included conditionally on a platform: https://github.com/xtensor-stack/xsimd/blob/5bb532075af7ee0f8a85f156215703fd652ba50b/include/xsimd/xsimd.hpp#L65-L74

[mreineck]

Thanks for testing this, I'll add the missing header as soon as possible!
Concerning xsimd, I think we need @DiamonDinoia's help ...

[mreineck]

The header file is now added to the master branch.

[barracuda156]

@mreineck It will be nice if the second issue is also addressed. I like when all my ports build LOL
(Since there is little hope that xsimd upstream adds support for powerpc, and I can’t handle Altivec myself, what we can do is just fall back to “normal”, unvectorized code.)

[mreineck]

Sure, but I don't know the first thing about xsimd, so I definitely can't fix it myself ...

[DiamonDinoia]

I can propose some workaround but the problem is that I cannot test this.

#ifdef XSIMD_NO_SUPPORTED_ARCHITECTURE
#endif

I was planning on restoring the old code as sometimes auto vectorization is a bit better.
Now we have one more reason to do so.

I am afraid this has to wait a bit. How urgent it is?

[barracuda156]

@DiamonDinoia That would be great!
No urgency, just update me once that is done, please.

[ahbarnett]

Hi Marco, good idea - I agree it's pretty important to have a fallback to the pre-xsimd spreadinterp code for platforms not supported by xsimd. I would raise the priority of this one so it is included in 2.5.

[DiamonDinoia]

As suggested here: xtensor-stack/xsimd#1143 (comment)

Would -DXSIMD_WITH_EMULATED=1 -DXSIMD_DEFAULT_ARCH=emulated<128> do the trick?

[DiamonDinoia]

@barracuda156 does this branch work on power-pc? https://github.com/DiamonDinoia/finufft/tree/restoring-scalar-code