apply_shifts_movie: Memory mapping block not generalized for 3D movies?

[rcalfredson]

In the function apply_shifts_movie (see line 477 of the current version), the block that saves the memory-mapped file uses the following code:

CaImAn/caiman/motion_correction.py

Line 477 in 0b5a9e1

big_mov[:] = np.reshape(m_reg.transpose(1, 2, 0), (np.prod(dims[1:]), dims[0]), order='F')

This transpose call (m_reg.transpose(1, 2, 0)) is hardcoded for a 3D array corresponding to a 2D movie (with shape (n_frames, height, width)). It works correctly for 2D movies but fails to generalize when the movie data is 3D (e.g., having a shape like (n_frames, height, width, depth)).

It seems like switching to moveaxis resolves this for both 2D and 3D, like this:

big_mov[:] = np.reshape(np.moveaxis(m_reg, 0, -1), (np.prod(dims[1:]), dims[0]), order='F')

Could this be a change work making to the function? Thanks very much.