Implementation of novb_heading2

[grizzi]

Hi, I have implemented the logic to make the NovbHeading2 msg available through the driver.

This is since we wanted to have access to the baseline measurements, to better detect GNSS outages. Could you give a look?
I will test this tomorrow.

Thanks!

[flipflip8952]

Nice, thanks! I've triggered the CI, let's see what it thinks... :)

[flipflip8952]

It isn't happy. Apply this patch:
0001-pre-commit.patch

(I unfortunately have no idea how I could commit that myself to this PR. Do you have any idea how this is supposed to work?)

[grizzi]

What if you try to contribute directly from our fork? Or did you get some permissions denied?

[flipflip8952]

I managed to use this "gh" cli to checkout your branch, which created a local branch in my workspace, but did not change/add any remote or so. So I didn't know where to push to. I tried this (suggested by git itself):

$ git push origin HEAD:refs/pull/95/head
Enumerating objects: 133, done.
Counting objects: 100% (133/133), done.
Delta compression using up to 16 threads
Compressing objects: 100% (100/100), done.
Writing objects: 100% (102/102), 18.49 KiB | 3.08 MiB/s, done.
Total 102 (delta 70), reused 0 (delta 0)
remote: Resolving deltas: 100% (70/70), completed with 23 local objects.
To github.com:fixposition/fixposition_driver.git
 ! [remote rejected] HEAD -> refs/pull/95/head (deny updating a hidden ref)
error: failed to push some refs to '[email protected]:fixposition/fixposition_driver.git'

[grizzi]

I thought that the easiest workflow is to contribute to our fork. So you do:

git clone [email protected]:Ascento-AG/fixposition_driver.git
cd fixposition_driver
git checkout novb_heading2
# do stuff 

The fork is public, so I think that it should work.

[flipflip8952]

OK, I added your copy as another remote and i can directly checkout your branch and modify it. Still, i cannot push of course (it's only publicly readable, but not writable of course).

$ git remote -v
ascento [email protected]:Ascento-AG/fixposition_driver.git (fetch)
ascento [email protected]:Ascento-AG/fixposition_driver.git (push)
origin  [email protected]:fixposition/fixposition_driver.git (fetch)
origin  [email protected]:fixposition/fixposition_driver.git (push)

$ git push ascento 
ERROR: Permission to Ascento-AG/fixposition_driver.git denied to flipflip8952.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I guess you could give me write permissions. But I see that you have already applied the patch, so no need for that today.. :-)

I've triggered again the CI

[grizzi]

this seems to be good to go :)

[grizzi]

Yes, I tested purely the running of the driver and the publishing of the new message :)

[flipflip8952]

I think you'll have to update main in your fork and the merge that into your PR or rebase your PR on new main. Not sure what the "associated with flifplip8952" means. I see no button "rebase" or "sync" or something like that.

[flipflip8952]

Yay, we did it! :-)
Many thanks for your contribution.
Happy hacking!