[Bug] Roll RE on to_subsidiary fiscal calendar

[jmongerlyra]

Is there an existing issue for this?

• I have searched the existing issues

Describe the issue

Current balance sheet model (v1.1.0) has net income rolling into retained earnings based on the root parent's fiscal calendar. In NetSuite, the retained earnings rollforward is dependent on fiscal calendar assigned to the to_subsidiary.

See NetSuite documentation here

Relevant error log or model output

n/a

Expected behavior

Retained earnings rollforward should be dependent on fiscal calendar assigned to the to_subsidiary rather than forcing the root parent.

Possible solution

See related PR.

dbt Project configurations

netsuite2__multibook_accounting_enabled: true
netsuite2__using_to_subsidiary: true
netsuite2__fiscal_calendar_enabled: true

Package versions

packages:

• package: fivetran/fivetran_utils
  version: [">=0.4.0", "<0.5.0"]

• package: dbt-labs/spark_utils
  version: [">=0.3.0", "<0.4.0"]

What database are you using dbt with?

snowflake

How are you running this dbt package?

dbt Core™

dbt Version

1.7.14

Additional Context

No response

Are you willing to open a PR to help address this issue?

• Yes.
• Yes, but I will need assistance.
• No.

[fivetran-jamie]

Hi @jmongerlyra -- thanks for opening your PR! The changes make sense to me and align with the Netsuite docs.

Was this issue present in v1.0.0 as well, or did you only see it appear in the latest v1.1.0 release?

[jmongerlyra]

@fivetran-jamie It was present in v1.0.0 as well.

[fivetran-jamie]

@jmongerlyra Great! Just wanted to make sure we didn't push out a bug in v1.1.0.

We'll review and incorporate your PR during our next sprint, which starts next Thursday 👍

[fivetran-jamie]

Hey @jmongerlyra some things came up this sprint and it looks like we don't have bandwidth to get to this rn. We'll review and push this out the following sprint -- you can definitely expect this to go out in November. Appreciate your patience

[fivetran-catfritz]

Hi @jmongerlyra I am picking this up, and it is scheduled to be released by the 26th.

[fivetran-catfritz]

Hi @jmongerlyra I have a release-candidate branch ready (PR link). Would you be able to give it a test when you have a moment?

I kept the updates you made and added logic for customers that are not using to_subsidiary. It is working on our test data, but I wanted to double-check that my updates didn’t introduce any issues on your side before we ship the release.

- git: https://github.com/fivetran/dbt_netsuite.git
  revision: feature/retained-earnings-to-sub-calendar
  warn-unpinned: false

[jmongerlyra]

@fivetran-catfritz I built netsuite2__balance_sheet using the feature/retained-earnings-to-sub-calendar branch. Numbers look good!

[fivetran-catfritz]

@jmongerlyra Awesome and thank you for confirming! I will release this Monday, since we decided not to push an update right before we close for Thanksgiving.