Switch to using the git_sha dockerfile arg for version fetching

This also entrily removes the need for having git as a dependanncy in the image

Author: ChrisLovering

Dockerfile

@@ -1,7 +1,5 @@
 FROM python:3.9-slim
 
-RUN apt-get update && apt-get -y install git
-
 # Set pip to have cleaner logs and no saved cache
 ENV PIP_NO_CACHE_DIR=false \
     PIPENV_IGNORE_VIRTUALENVS=1 \

bot/cogs/utilities.py

@@ -1,7 +1,6 @@
 from asyncio import sleep
 from pathlib import Path
 import random
-import subprocess
 from typing import Optional
 
 from discord import Colour, Embed
@@ -129,14 +128,9 @@ async def after_create_reminder() -> None:
             await ctx.send(msg)
 
     @command(brief="Returns Friendo's Version")
-    async def version(self, ctx: Context) -> str:
+    async def version(self, ctx: Context) -> None:
         """Creates a version number from settings.VERSION and most recent commit hash."""
-        commit_hash = (subprocess.check_output(["git", "rev-parse", "HEAD"]).strip().decode("ascii"))
-        msg = f"Version is {settings.VERSION}{commit_hash[-4:]}"
-
-        await ctx.send(msg)
-
-        return msg
+        await ctx.send(f"Version is {settings.VERSION}+{settings.GIT_SHA}")
 
     @command(brief="[number] [unit (seconds/minutes/hours)] [reason for reminder]", aliases=["remind"])
     async def reminder(self, ctx: Context, time: str, period: str = "minutes", *, reason: str = None) -> None:

bot/settings.py

@@ -26,6 +26,8 @@
 FRIENDO_API_PASS = environ.get("FRIENDO_API_PASS")
 FRIENDO_API_URL = environ.get("FRIENDO_API_URL", "http://dev.friendo.dev/api/")
 
+GIT_SHA = environ.get("GIT_SHA", "development")
+
 log.info(f"Using {FRIENDO_API_URL} for backend...")
 
 VERSION = "1.2"