Some feedback

[filipbech]

Thanks for the work. This could turn out very useful for many people...

I like the approach, and would love for this to be developed further. A couple of comments/questions though.
Also, please let me know if you want more code-style/QA feedback - Im happy to help.

• iPod? You only initiate if platform is iPad or iPhone (ln 152), but later you check to see if its iPod (ln 121)
• best-icon? why not just add them all and let the browser do the magic. If safari changes its logic this would no longer follow the platform as intented
• I think web-app manifest urls are calculated from the base-url, which XHR is not. Minor thing, but base-urls are very common when routing clientside

I would love to see the start_url thing implemented like Paul Kinlands issue...

[firtman]

Thanks @filipbech

• Regarding iPod miss, I'll check it.
• For the best icon, there is an explanation: there is a bug today on iOS where when you add the page to the homescreen, a screenshot is taken instead of the icon; it happens randomly, and I'm talking only when the network is still up. Is the network is down when the user presses "Add to Home Screen", then the icon will never appear, therefore the best approach today is to set the icon in base64 to guarantee it's going to be used by Safari. It's part of my ToDo list, but that's the reason why I didn't let Safari just pick the icon.
• I'll do a test suite for the base-url thing; sounds like something to be solved.

Regarding start_url like Paul says, look at my answer. I think I'm probably missing something there.

[filipbech]

thanks for getting back to me... great explanation of the ios icon-bug... i didn't know that!
You can close this issue as it was just for getting in touch...
let me know if there is anything I can do to help!