fix: catch errors when checking github for firmware updates (#215)

* fix: catch errors when checking github for firmware updates

* catch aiohttp errors better

* update tests

* fix test

Author: firstof9

openevsehttp/__main__.py

@@ -492,28 +492,38 @@ async def firmware_check(self) -> dict | None:
         else:
             url = f"{base_url}ESP8266_WiFi_v2.x/releases/latest"
 
-        async with aiohttp.ClientSession() as session:
-            http_method = getattr(session, method)
-            _LOGGER.debug(
-                "Connecting to %s using method %s",
-                url,
-                method,
-            )
-            async with http_method(url) as resp:
-                if resp.status != 200:
-                    return None
-                message = await resp.text()
-                message = json.loads(message)
-                response = {}
-                response["latest_version"] = message["tag_name"]
-                release_notes = message["body"]
-                response["release_summary"] = (
-                    (release_notes[:253] + "..")
-                    if len(release_notes) > 255
-                    else release_notes
+        try:
+            async with aiohttp.ClientSession() as session:
+                http_method = getattr(session, method)
+                _LOGGER.debug(
+                    "Connecting to %s using method %s",
+                    url,
+                    method,
                 )
-                response["release_url"] = message["html_url"]
-                return response
+                async with http_method(url) as resp:
+                    if resp.status != 200:
+                        return None
+                    message = await resp.text()
+                    message = json.loads(message)
+                    response = {}
+                    response["latest_version"] = message["tag_name"]
+                    release_notes = message["body"]
+                    response["release_summary"] = (
+                        (release_notes[:253] + "..")
+                        if len(release_notes) > 255
+                        else release_notes
+                    )
+                    response["release_url"] = message["html_url"]
+                    return response
+
+        except (TimeoutError, ServerTimeoutError):
+            _LOGGER.error("%s: %s", ERROR_TIMEOUT, url)
+        except ContentTypeError as err:
+            _LOGGER.error("%s", err)
+        except aiohttp.ClientConnectorError as err:
+            _LOGGER.error("%s : %s", err, url)
+
+        return None
 
     def _version_check(self, min_version: str, max_version: str = "") -> bool:
         """Return bool if minimum version is met."""

tests/test_main.py

@@ -1,5 +1,7 @@
 """Library tests."""
 
+import aiohttp
+from aiohttp.client_reqrep import ConnectionKey
 import asyncio
 import json
 import logging
@@ -950,6 +952,21 @@ async def test_firmware_check(
     firmware = await test_charger.firmware_check()
     assert firmware == None
 
+    mock_aioclient.get(
+        TEST_URL_GITHUB_v4,
+        exception=aiohttp.ClientConnectorError(
+            ConnectionKey("localhost", 80, False, None, None, None, None),
+            OSError(ConnectionError),
+        ),
+    )
+    with caplog.at_level(logging.DEBUG):
+        firmware = await test_charger.firmware_check()
+        assert (
+            f"Cannot connect to host localhost:80 ssl:default [None] : {TEST_URL_GITHUB_v4}"
+            in caplog.text
+        )
+    assert firmware is None
+
     await test_charger_dev.update()
     mock_aioclient.get(
         TEST_URL_GITHUB_v4,