Skip to content

Commit 05c2a31

Browse files
authored
fix: adjust firmware lower limits for v2.x firmware devices (#456)
* fix: adjust firmware lower limits for v2.x firmware devices * version bump * fix test
1 parent c596358 commit 05c2a31

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

openevsehttp/__main__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ async def set_charge_mode(self, mode: str = "fast") -> None:
353353

354354
async def divert_mode(self) -> dict[str, str] | dict[str, Any]:
355355
"""Set the divert mode to either Normal or Eco modes."""
356-
if not self._version_check("4.0.0"):
356+
if not self._version_check("2.9.1"):
357357
_LOGGER.debug("Feature not supported for older firmware.")
358358
raise UnsupportedFeature
359359

@@ -539,7 +539,7 @@ async def firmware_check(self) -> dict | None:
539539
url = None
540540
method = "get"
541541

542-
cutoff = AwesomeVersion("4.0.0")
542+
cutoff = AwesomeVersion("3.0.0")
543543
current = ""
544544

545545
_LOGGER.debug("Detected firmware: %s", self._config["version"])
@@ -652,7 +652,7 @@ def _version_check(self, min_version: str, max_version: str = "") -> bool:
652652
# HTTP Posting of grid voltage
653653
async def grid_voltage(self, voltage: int | None = None) -> None:
654654
"""Send pushed sensor data to grid voltage."""
655-
if not self._version_check("4.0.0"):
655+
if not self._version_check("2.9.1"):
656656
_LOGGER.debug("Feature not supported for older firmware.")
657657
raise UnsupportedFeature
658658

@@ -678,7 +678,7 @@ async def self_production(
678678
voltage: int | None = None,
679679
) -> None:
680680
"""Send pushed sensor data to self-prodcution."""
681-
if not self._version_check("4.0.0"):
681+
if not self._version_check("2.9.1"):
682682
_LOGGER.debug("Feature not supported for older firmware.")
683683
raise UnsupportedFeature
684684

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
PROJECT_DIR = Path(__file__).parent.resolve()
88
README_FILE = PROJECT_DIR / "README.md"
9-
VERSION = "0.1.84"
9+
VERSION = "0.1.85"
1010

1111
setup(
1212
name="python_openevse_http",

tests/test_main.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1008,8 +1008,7 @@ async def test_set_divertmode(
10081008
body=value,
10091009
)
10101010
await test_charger_v2.update()
1011-
with pytest.raises(UnsupportedFeature):
1012-
await test_charger_v2.divert_mode()
1011+
await test_charger_v2.divert_mode()
10131012

10141013
mock_aioclient.post(
10151014
TEST_URL_CONFIG,

0 commit comments

Comments
 (0)