Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in smokeview HVAC writes #14421

Open
drjfloyd opened this issue Mar 26, 2025 · 0 comments
Open

bug in smokeview HVAC writes #14421

drjfloyd opened this issue Mar 26, 2025 · 0 comments
Assignees
@drjfloyd

Comments

@drjfloyd
Copy link
Contributor

If there is more than one waypoint for a duct this block in dump.f90 will cause an error:

  IF (DUCT(N)%N_WAYPOINTS > 0) THEN
     WRITE(MYSTR,'(1X,3F12.5)') (DUCT(N)%WAYPOINT_XYZ(NN,1),DUCT(N)%WAYPOINT_XYZ(NN,2),&
                                 DUCT(N)%WAYPOINT_XYZ(NN,3),NN=1,DUCT(N)%N_WAYPOINTS); CALL ADDSTR
  ENDIF

Putting the loop around the write rather than in the write appears to fix the problem.
@drjfloyd drjfloyd self-assigned this Mar 26, 2025
drjfloyd added a commit to drjfloyd/fds that referenced this issue Mar 26, 2025
@drjfloyd
FDS Source: Fix issue firemodels#14421 by moving loop outside of write
d8360d4
drjfloyd added a commit that referenced this issue Mar 26, 2025
@drjfloyd
Merge pull request #14422 from drjfloyd/master
869d893 
FDS Source: Fix issue #14421 by moving loop outside of write
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drjfloyd drjfloyd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drjfloyd