Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lattimer Tilted Wall Val Guide #14297

Open
drjfloyd opened this issue Feb 28, 2025 · 8 comments
Open

Lattimer Tilted Wall Val Guide #14297

drjfloyd opened this issue Feb 28, 2025 · 8 comments
Assignees

Comments

@drjfloyd
Copy link
Contributor

I ran all the Lattimer tilted wall cases. Was about to move the new results to the .out folder. But that folder currently has a single pair of files (devc and line) for the 20 kW 0 degree case. The current FDS files do not create a line file (only a devc) and there are many more input files than just the 20 kW 0.

What files need to be put in out? Do the fds inputs need to be edited to create a line file? If we are not using all the various inputs file should we remove them from the repo so we are not spending time running them?

@johodges
Copy link
Collaborator

Thanks for the reminder. These were in flux when we were dealing with the GEOM radiation issues. I think we want to benchmark with them going forward. I can add the devices and get them added to dataplot.

@rmcdermo
Copy link
Contributor

OK, thanks @johodges

@johodges
Copy link
Collaborator

johodges commented Mar 1, 2025

Quick update on this. I have updated input files, dataplot, and the guide for these. Still waiting on the runs to finish before adding to out and sending the PRs. I should have results in the next day or 2 so we can get these pulled in to master.

One thing I noticed is that we do see artifacts at the mesh boundary.

Image

@marcosvanella
Copy link
Contributor

Are these devices that are defined in inter-mesh boundaries?

@johodges
Copy link
Collaborator

johodges commented Mar 2, 2025

Yep, these are line devices defined along a rotated GEOM that crosses a mesh boundary. The input file for the bottom right figure is here:

https://github.com/johodges/fds/blob/master/Validation/Lattimer_Tilted_Wall/FDS_Input_Files/Lattimer_50_kW_67_degree.fds

@marcosvanella
Copy link
Contributor

I don't see an issue in the BNDF of Gauge heat flux, two devices for GHF at z=0.2m are not getting updated. Using these lines only for devices 23-26 of the line:

&DEVC ID='GFH1', XYZ=-4.5565667E-001, 0., 1.9341667E-001, IOR=1, QUANTITY='GAUGE HEAT FLUX'/
&DEVC ID='GFH2', XYZ=-4.7636833E-001, 0., 2.0220833E-001, IOR=1, QUANTITY='GAUGE HEAT FLUX'/
&DEVC ID='GFH3', XYZ=-4.9708000E-001, 0., 2.1100000E-001, IOR=1, QUANTITY='GAUGE HEAT FLUX'/
&DEVC ID='GFH4', XYZ=-5.1779167E-001, 0., 2.1979167E-001, IOR=1, QUANTITY='GAUGE HEAT FLUX'/

I see:

s,kW/m2,kW/m2,kW/m2,kW/m2
Time,"GFH1","GFH2","GFH3","GFH4"
 0.0000000E+000,-4.2721136E-003,-4.1876582E-001,-4.1876582E-001,-4.2721232E-003
 1.0897960E+000,-2.2804237E-003,-4.1876582E-001,-4.1876582E-001,-4.6297671E-003
 2.1803200E+000, 1.8570212E-001,-4.1876582E-001,-4.1876582E-001,-5.1644532E-003
 3.0793161E+000, 3.9751184E-001,-4.1876582E-001,-4.1876582E-001,-4.3188657E-003
 4.0228853E+000, 4.3645182E-001,-4.1876582E-001,-4.1876582E-001, 1.0162266E-002
 5.0899496E+000, 7.7618663E-001,-4.1876582E-001,-4.1876582E-001, 2.5511309E-001
 6.0140836E+000, 9.4996182E-001,-4.1876582E-001,-4.1876582E-001, 4.2474883E-001
 7.0327145E+000, 1.4199518E+000,-4.1876582E-001,-4.1876582E-001, 7.1999997E-001
 8.0136078E+000, 2.3466880E+000,-4.1876582E-001,-4.1876582E-001, 1.1136340E+000
 9.0241490E+000, 1.9916238E+000,-4.1876582E-001,-4.1876582E-001, 1.8033976E+000

where GFH2 and GFH3 don't get updated. Those two are not paired to a CFACE, need to understand why.

@johodges
Copy link
Collaborator

johodges commented Mar 3, 2025

@rmcdermo I am assuming we want to wait on merging these in until after the minor release bundle is built. Let me know if you want them pulled in before.

@marcosvanella
Copy link
Contributor

There is an assumption when pairing devices that the search for solid CFACES will happen only if a wall cell has not been found (IW==0). Turns out here a wall cell has been found, but is of type INTERPOLATED. We need an extra test for pairing DV to CFACES next to external wall cells. I'm testing a solution for this.

I don't see an issue in the BNDF of Gauge heat flux, two devices for GHF at z=0.2m are not getting updated. Using these lines only for devices 23-26 of the line:

&DEVC ID='GFH1', XYZ=-4.5565667E-001, 0., 1.9341667E-001, IOR=1, QUANTITY='GAUGE HEAT FLUX'/
&DEVC ID='GFH2', XYZ=-4.7636833E-001, 0., 2.0220833E-001, IOR=1, QUANTITY='GAUGE HEAT FLUX'/
&DEVC ID='GFH3', XYZ=-4.9708000E-001, 0., 2.1100000E-001, IOR=1, QUANTITY='GAUGE HEAT FLUX'/
&DEVC ID='GFH4', XYZ=-5.1779167E-001, 0., 2.1979167E-001, IOR=1, QUANTITY='GAUGE HEAT FLUX'/

I see:

s,kW/m2,kW/m2,kW/m2,kW/m2
Time,"GFH1","GFH2","GFH3","GFH4"
 0.0000000E+000,-4.2721136E-003,-4.1876582E-001,-4.1876582E-001,-4.2721232E-003
 1.0897960E+000,-2.2804237E-003,-4.1876582E-001,-4.1876582E-001,-4.6297671E-003
 2.1803200E+000, 1.8570212E-001,-4.1876582E-001,-4.1876582E-001,-5.1644532E-003
 3.0793161E+000, 3.9751184E-001,-4.1876582E-001,-4.1876582E-001,-4.3188657E-003
 4.0228853E+000, 4.3645182E-001,-4.1876582E-001,-4.1876582E-001, 1.0162266E-002
 5.0899496E+000, 7.7618663E-001,-4.1876582E-001,-4.1876582E-001, 2.5511309E-001
 6.0140836E+000, 9.4996182E-001,-4.1876582E-001,-4.1876582E-001, 4.2474883E-001
 7.0327145E+000, 1.4199518E+000,-4.1876582E-001,-4.1876582E-001, 7.1999997E-001
 8.0136078E+000, 2.3466880E+000,-4.1876582E-001,-4.1876582E-001, 1.1136340E+000
 9.0241490E+000, 1.9916238E+000,-4.1876582E-001,-4.1876582E-001, 1.8033976E+000

where GFH2 and GFH3 don't get updated. Those two are not paired to a CFACE, need to understand why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants